Fix #2390: don't silently truncate CSV columns, handle preamble row - #2410
Open
Mohamed Elfeky (FekyBaz) wants to merge 1 commit into
Open
Fix #2390: don't silently truncate CSV columns, handle preamble row#2410Mohamed Elfeky (FekyBaz) wants to merge 1 commit into
Mohamed Elfeky (FekyBaz) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2390.CsvConverter treated rows[0] as header unconditionally and silently truncated wider data rows via row[:len(rows[0])].Adds two behaviors:- Preamble heuristic: lone single-field first row followed by a wider row is emitted as plain text and the second row becomes the header (covers WizTree exports whose line 1 is a banner and line 2 is the real header).- No silent loss otherwise: table widens to max row width with a UserWarning instead of truncating.Also avoids mutating parsed rows in place.Short rows are still padded; empty inner rows keep existing behavior.Verified with WizTree repro plus existing CSV expectations (BOM, blank rows, pipe escaping).