docs(network): use lower-cased header name in delete header samples - #42573
Open
Armin Azar (armin-azar) wants to merge 1 commit into
Open
docs(network): use lower-cased header name in delete header samples#42573Armin Azar (armin-azar) wants to merge 1 commit into
Armin Azar (armin-azar) wants to merge 1 commit into
Conversation
request.headers() returns lower-cased header names, so removing "X-Secret" never matches. The JavaScript, Java and C# samples silently keep the header instead of removing it as the surrounding text states. The Python samples already use the lower-cased name.
Author
|
Max Schmitt (@mxschmitt) mind taking a look when you get a chance? Small one. The delete header samples use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request.headers()returns lower-cased header names, soX-Secretnever matches and the "Delete header" samples for JavaScript, Java and C# silently leave the header in place instead of removing it.