chat: add Configure Tools action to permissions picker - #332776
Closed
sukumarp2022 wants to merge 24 commits into
Closed
chat: add Configure Tools action to permissions picker#332776sukumarp2022 wants to merge 24 commits into
sukumarp2022 wants to merge 24 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Configure tools action to the chat permissions picker for direct access to terminal auto-approval settings.
Changes:
- Adds the gear action to built-in Default permissions.
- Adds accessibility help and focused tests.
- Updates fixtures and Agent Host dependency wiring.
Show a summary per file
| File | Description |
|---|---|
permissionPickerList.fixture.ts |
Displays the new action in fixtures. |
sessionTargetPickerActionItem.test.ts |
Tests permission-picker behavior. |
chatAccessibilityHelp.test.ts |
Tests accessibility help text. |
permissionPickerActionItem.ts |
Implements the Configure tools action. |
chatAccessibilityHelp.ts |
Documents the action. |
agentHostPermissionPickerActionItem.ts |
Wires the preferences service. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
Bryan Chen (bryanchen-d)
assigned
Justin Chen (justschen) and unassigned
Bryan Chen (bryanchen-d)
# Conflicts: # src/vs/workbench/contrib/chat/test/browser/widget/input/sessionTargetPickerActionItem.test.ts
Collaborator
|
closing in favor of #334972 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332775
Summary
Adds a Configure tools gear button to the Default permissions row in the Chat permissions picker.
Clicking it opens Settings directly to
chat.tools.terminal.autoApprove.The change also includes:
Testing