Update completion test for files.exclude configuration - #332809
Open
Deniz Güney Yıldırım (denizguney) wants to merge 5 commits into
Open
Update completion test for files.exclude configuration#332809Deniz Güney Yıldırım (denizguney) wants to merge 5 commits into
Deniz Güney Yıldırım (denizguney) wants to merge 5 commits into
Conversation
Copilot started reviewing on behalf of
Deniz Güney Yıldırım (denizguney)
August 26, 2026 20:07
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates files.exclude completion coverage for boolean values.
Changes:
- Tests completing
truefor a folder exclusion pattern.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Ross (alexr00)
assigned
Martin Aeschlimann (aeschli) and unassigned
Alex Ross (alexr00)
Martin Aeschlimann (aeschli)
requested changes
Sep 2, 2026
Martin Aeschlimann (aeschli)
left a comment
Martin Aeschlimann (aeschli)
left a comment
Contributor
There was a problem hiding this comment.
See the review comment. Also it looks like there'san extra space before 'test'
Removed commented-out code related to 'files.exclude' completion tests.
Replace 'in' with 'new' keyword when instantiating vscode.Range in setTestContent
Contributor
Author
|
Thanks for the feedback I've removed the extra space before 'test' and fixed the range syntax. Ready for another review. |
Martin Aeschlimann (aeschli)
enabled auto-merge (squash)
September 7, 2026 19:31
Martin Aeschlimann (aeschli)
approved these changes
Sep 7, 2026
Alexandru Dima (alexdima)
approved these changes
Sep 7, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test case for
files.excludecompletion incompletion.test.tsto ensure proper handling and validation of folder/pattern completion.