Repository navigation
Run log: record check and regen runs - #225
Merged
Merged
Conversation
…where, drop ci field, more tests, docs
…pt-out fixture, docs
Member
|
Thanks, @codefrenzy ! I tried it out — works reliably. I think this is a design doc gap but the initial For now, we can skip the exact error text as long as it's clear whether it was a ts or dfy catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@graciolli-f @namin
Summary
The first part of
DESIGN_RUN_LOG.md. Every Dafnylsc checkandlsc regenappends one record to.lemmascript/runs.jsonl(stage reached, members passed and failed,.tsand.dfyhashes) and snapshots the.ts. The directory ignores itself in git, and logging never changeslscoutput or exit codes.lsc runs, claimcheck records and reports come in later PRs.Changes from the design
The design doc is updated to match; reasons are there.
partialflag, so a run that didn't check every member can't make one look dropped.v) and a UUIDidon every record, so the format can evolve and records stay unique if logs are ever combined.LSC_RUN_LOGtakestrue/false, like the config; anything else is an error.Testing
New unit tests in
tools/tests/run-log.test.ts(fakedafnyonPATH, as indafny-regen.test.ts) and real-Dafny fixtures intest-fixtures.sh; existing fixtures run with logging off. Full suite 191/191, both typechecks,test-fixtures.shandregen-lean.shpass.Open question
Capturing Dafny's error text needs piped output, which would make check/regen async. Worth it, or decide once there's a real log to look at?