Skip to content

Command calls undefined getContainer function #138

Open

Description

@carlos-granados

The setLoggerService function in the run command calls the getContainer() function which no longer exists because the command no longer extends the ContainerAwareCommand class

Activity

  1. added a commit that references this issue on Nov 18, 2020
  2. mmucklo commented on Nov 20, 2020

    @mmucklo
    Owner

    @carlos-granados can you try with the latest version?

  3. carlos-granados commented on Nov 20, 2020

    @carlos-granados
    ContributorAuthor

    @mmucklo yes, all good now :-)

  4. carlos-granados commented on Nov 20, 2020

    @carlos-granados
    ContributorAuthor

    @mmucklo Actually, it would be useful if the runLoop, logger and container properties were protected instead of private. This would allow us to easily extend this command.

  5. carlos-granados commented on Nov 20, 2020

    @carlos-granados
    ContributorAuthor

    Either that or add some getters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions