Repository navigation
Let the per-file counts guards keep restate themselves with -u and name the line and number - #1201
Merged
Merged
Conversation
…me the line and number when red
Member
Author
|
Review verdict: approve (c5fa848). Each counting guard now fails with the file, the line and the number to write, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first outside contribution went red on an internal count a guard keeps by hand, which its author could neither see nor run.
Four guards keep a count per file (the import clauses per file, the commands each page hands over in two guards, the passages of the overwrite recipe per page). Now:
pnpm vitest run <the guard's file> -urewrites exactly those numbers in place, the way-urewrites a golden;-unever lets them in.Kept by hand on purpose: the ledgers of reasons (the unwitnessed files, the allowed escapes, the instrument list of the rulers guard), whose point is the sentence a person writes.
CONTRIBUTING.md says a red count is fixed by the command it names and that a maintainer does it when the contributor cannot.