Repository navigation
Daniella fix - #8759
Daniella fix#8759NBKelly wants to merge 9 commits into
Conversation
| [game.utils :refer [enumerate-cards enumerate-str quantify same-card?]])) | ||
|
|
||
| (defn- can-forfeit? [card] (not (get-in card [:flags :cannot-forfeit]))) | ||
| (defn- side-paid-msg [side] (keyword (str "paid/" (name side) "-msg"))) |
There was a problem hiding this comment.
One of my goals with namespacing the keywords is to improve searching, so this should be explicit (even tho it's not "DRY"):
(if (= :corp side) :paid/corp-msg :paid/runner-msg)
|
hmm actually, on second thought, i don't think we need the |
|
which is to say, the daniella fix is good, the engine changes shouldn't be necessary, but don't do anything just yet. |
|
Your changes will allow for payment messages (potentially) having hidden info? That's the last block for side-specific messages before I can go through the old card pool and fix up all the old cards, and what I'm hoping to get here. |
|
sort of. the work i did converts all of the costs to use the new message maps, which includes the ability for side-dependent rendering, and i think we can put them there. |
|
|
||
| (defn- can-forfeit? [card] (not (get-in card [:flags :cannot-forfeit]))) | ||
| (defn- side-paid-msg [side] (keyword (str "paid/" (name side) "-msg"))) | ||
| (defn- side-zone [side zone] |
There was a problem hiding this comment.
There isn't a helper for this? It seems like there should be. (Yes, this is just a clean-up thing.)
|
i've opened this PR locally and i'm making it work with #8748 and then i'll merge it locally and push, so you don't have to do anything extra. |
This adds support for additional trash costs.
Daniella now applies one of these. This also adds support for hidden info in payment messages.
Closes #8754