Skip to content

docs: replace dead chatbot-ui example link with repo root - #11546

Open
yzxcj797 wants to merge 1 commit into
mudler:masterfrom
yzxcj797:fix/dead-example-link
Open

docs: replace dead chatbot-ui example link with repo root#11546
yzxcj797 wants to merge 1 commit into
mudler:masterfrom
yzxcj797:fix/dead-example-link

Conversation

@yzxcj797

Copy link
Copy Markdown

The advanced-usage docs link to LocalAI-examples/tree/main/chatbot-ui which returns 404 — the chatbot-ui directory was removed from the examples repo. Updated to point to the repo root, which is live and still shows available examples.

@localai-org-maint-bot localai-org-maint-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new URL resolves, but the link text still identifies the repository root as chatbot-ui. That example no longer exists. Please replace the sentence with an accurate link, for example:

See the LocalAI configuration examples for more sample config files.

The DCO check also reports that this commit lacks your Signed-off-by trailer. Please add your own sign-off and push the updated commit. Maintainers cannot provide this legal attestation for you.

@localai-org-maint-bot

Copy link
Copy Markdown
Collaborator

Review pass, following up after 18 days.

Two small things, both of which only you can fix:

DCO. The single commit 4eff44a0 has an empty body and no Signed-off-by, so the DCO check fails. Amending with the trailer is all that is needed.

The link text still describes content that no longer exists. The change at docs/content/advanced/advanced-usage.md:41 swaps the dead deep link for the repo root, but the sentence still says "See also chatbot-ui", naming an example that was removed. So the page stays wrong after the change.

docs/content/getting-started/models.md:337 already links LocalAI-examples/tree/main/configurations for exactly this purpose, which is probably the right target and the right wording to mirror.

This is a two-minute fix and the underlying problem is real, so it would be good to land.

@localai-org-maint-bot

Copy link
Copy Markdown
Collaborator

Thanks for this PR! The DCO check is failing because the commits are not signed off. Please amend your commits with git commit --amend --signoff (or rebase with git rebase --signoff) and force-push. The Developer Certificate of Origin requires a Signed-off-by: Your Name <email> trailer on every commit.

@localai-org-maint-bot

Copy link
Copy Markdown
Collaborator

Thanks — the link fix is correct. Just needs DCO signoff on the commit to merge:

git rebase --signoff HEAD~1
git push --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants