Skip to content

make pr / make docs fail after recent API merges (ruff RUF043 + Sphinx docstring) #145

Description

@acul71

Summary

After landing the recent go-parity / polish PRs (#136–#144), a clean checkout of master fails local PR gates:

  1. make pr / ruff — tests/test_protocols.py uses a non-raw match= pattern with regex metacharacters (RUF043).
  2. make docs / Sphinx -W — multiaddr.utils.from_net_addr docstring has a multi-line Args definition list that Sphinx treats as a warning-as-error.
  3. Docs inventory — docs/multiaddr.rst (sphinx-apidoc) does not yet list the new multiaddr.filters module.

Expected

  • make pr passes
  • make docs / make docs-ci passes with SPHINXOPTS="-W"

Proposed fix

  • Use a raw-string regex in the wg negative test (match=r"...")
  • Flatten the from_net_addr Args docstring to a single-line description
  • Add multiaddr.filters automodule section to docs/multiaddr.rst

Notes

A direct commit previously landed these changes on master without GitHub tox CI (workflow only runs on pull_request and pushes to main / github-actions). This issue tracks landing the same fix via a proper PR so Actions can validate it.

Activity

  1. added a commit that references this issue on Sep 20, 2026
    e232e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions