[fmunkes]

What does this implement/fix?

Seeking to 0:00 (seek bar, chapter 1) restarted an audiobook or episode at its resume point, because play_index read 0 as "no position given". The public play_index keeps that behaviour for clients, and seek() now calls a private _play_index directly. Most of the diff is the unchanged body moving to the bottom of the file. The actual change:

     async def seek(self, queue_id: str, position: int = 10) -> None:
-        await self.play_index(queue_id, queue.current_index, seek_position=position)
+        await self._play_index(queue_id, queue.current_index, position, fade_in=False)

     async def play_index(self, queue_id, index, seek_position: int = 0, fade_in=False) -> None:
         self._check_player_permission(queue_id)
+        await self._play_index(queue_id, index, seek_position or None, fade_in)

+    async def _play_index(self, queue_id, index, seek_position: int | None, fade_in: bool) -> None:
         ...
-            if (
-                not seek_position
-                and not restarting_ended_queue
-                and (queue_item := self.get_item(queue_id, index))
-            ):
-                seek_position = await self._get_resume_position(queue_item)
+            if seek_position is None:
+                seek_position = (
+                    await self._get_resume_position(queue_item)
+                    if not restarting_ended_queue and (queue_item := self.get_item(queue_id, index))
+                    else 0
+                )

Related issue (if applicable):

• Audiobook: seeking to 0:00 or picking chapter 1 jumps back to the saved resume position support#6977

Types of changes

• Bugfix (non-breaking change which fixes an issue) — bugfix
• New feature (non-breaking change which adds functionality) — new-feature
• Enhancement to an existing feature — enhancement
• New music/player/metadata/plugin provider — new-provider
• Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
• Refactor (no behaviour change) — refactor
• Documentation only — documentation
• Maintenance / chore — maintenance
• CI / workflow change — ci
• Dependencies bump — dependencies

Checklist

• The code change is tested and works locally.
• pre-commit run --all-files passes.
• pytest passes, and tests have been added/updated under tests/ where applicable.
• For changes to shared models, the companion PR in music-assistant/models is linked.
• For changes affecting the UI, the companion PR in music-assistant/frontend is linked.
• I have read and complied with the project's AI Policy for any AI-assisted contributions.
• I have raised a PR against the documentation repository targeting the main or beta branch as appropriate.

[Bot-MArley]

Note

This comment was written by Claude and posted by Bot-MArley on behalf of the Music Assistant maintainers.

This fixes seeking to 0:00 on an audiobook or episode: seek() now calls a private _play_index so a position of 0 means "start at 0" instead of "use the resume point", while the public play_index keeps its old behaviour for clients. Most of the diff is the unchanged body moving to the bottom of the file.

I read the whole diff and found nothing to change. seek() still has @handle_play_action and its own permission check, and the other play_index callers behave as before. CI is green, so this is waiting for a maintainer to review and merge.

[OzGav]

This looks good but needs a careful rebase after #7395

[Bot-MArley]

Note

This comment was written by Claude and posted by Bot-MArley on behalf of the Music Assistant maintainers.

This only brings the branch up to date with dev (the rebase after #7395); the PR's own change to seeking to 0:00 is unchanged and I found no issues in it.

Requested changes: none. Checks are green, so it waits for a maintainer to merge; the earlier approval was on the previous commit.

[OzGav]

@fmunkes can you have another look?