Skip to content

pragma: fix NULL-pointer dereference on malformed --pragma input #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cherry530 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pragma: fix NULL-pointer dereference on malformed --pragma input #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions asm/pragma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,15 @@ void process_pragma(char *str)
* interior spaces.
*/
p = nasm_zap_spaces_fwd(p);
if (p == NULL) {
/* Missing opname and/or options; avoid a NULL-pointer
* dereference in strlen() below. Report it explicitly
* instead of crashing. */
nasm_error(ERR_NONFATAL, "bad argument to %%pragma %s: missing opname",
pragma.facility_name ? pragma.facility_name : "");
pragma.tail = NULL;
return;
}
pragma.tail = p;
p += strlen(p);
while (p > pragma.tail && nasm_isspace(p[-1]))
Expand Down