Skip to content

assemble: fix broadcast ratio calculation for sub-64-bit vector operands #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agourakis82 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

assemble: fix broadcast ratio calculation for sub-64-bit vector operands #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions asm/assemble.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/

#include "compiler.h"
#include "ilog2.h"


#include "nasm.h"
Expand Down Expand Up @@ -2977,20 +2978,18 @@ static enum match_result find_match(insn *instruction)

static uint8_t get_broadcast_num(opflags_t opflags, opflags_t brsize)
{
static const uint16_t size_bits[8] = { 8, 16, 32, 64, 80, 128, 256, 512 };
unsigned int opsize = (opflags & SIZE_MASK) >> SIZE_SHIFT;
uint8_t brcast_num;
unsigned int brsize_idx;

if (brsize > BITS64)
nasm_fatal("size of broadcasting element is greater than 64 bits");

/*
* The shift term is to take care of the extra BITS80 inserted
* between BITS64 and BITS128.
*/
brcast_num = ((opsize / (BITS64 >> SIZE_SHIFT)) * (BITS64 / brsize))
>> (opsize > (BITS64 >> SIZE_SHIFT));
brsize_idx = (brsize & SIZE_MASK) >> SIZE_SHIFT;
if (!opsize || !brsize_idx)
return 0;

return brcast_num;
return size_bits[ilog2_32(opsize)] / size_bits[ilog2_32(brsize_idx)];
}

static enum match_result matches(const struct itemplate * const itemp,
Expand Down