Skip to content

Add "suggested_server" to Login screen - #17506

Merged
alperozturk96 merged 1 commit into
masterfrom
suggestedServer
Sep 16, 2026
Merged

alperozturk96 merged 1 commit into
masterfrom
suggestedServer

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32258414777/artifacts/9367457800
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)


<!-- [{\"name\":\"name1\",\"url\":\"url\"},{\"name\":\"name2\",\"url\":\"url1\"}]-->
<string name="enforce_servers" translatable="false"></string>
<string name="suggested_server" translatable="false"></string>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing just add a server, e.g. https://nextcloud.local

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

(i rebased because it was somehow referencing an android-library version not available in JitPack)

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk (512)
QR code Open the QR code for this download
Commit 3844bde
Version 17506
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total361361

@alperozturk96
alperozturk96 merged commit bbf71f8 into master Sep 16, 2026
24 of 25 checks passed
@alperozturk96
alperozturk96 deleted the suggestedServer branch September 16, 2026 06:13
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 16, 2026
@alperozturk96

Copy link
Copy Markdown
Collaborator

/backport to stable-35.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants