perf(media): improvement

[alperozturk96]

Changes

• Removes ThumbnailMemoryCache introduced via new media player PR
• Cancels previous gallery job onViewRecycled
• Caches button bitmaps
• Updates adapter only when content actually changed
• Fixes placeholder size
• Fixes placeholder icon inner padding
• Adds loading spinner to the gallery during load
• Improves scroll perfomance

[alperozturk96]

/backport to stable-35.0.x

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/34573192442/artifacts/10189703611
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[daniele-verducci]

Hey Alper,
very smooth and fast experience!

However, I found a couple of issues:

Placeholder covers video thumbnail:

When selecting a video, it lands on the previous one:

• Open Media
• Filter videos only
• Open a video near the end of the list
• Go back to PIP mode
• Open a video upper on the list
• It shows the previous one

(this was probably there since the media enhancement PR, but I didn't catch it before...)

Screen_recording_20260911_104255.mp4

[alperozturk96]

Hey Alper, very smooth and fast experience!

However, I found a couple of issues:

Placeholder covers video thumbnail:

When selecting a video, it lands on the previous one:

• Open Media
• Filter videos only
• Open a video near the end of the list
• Go back to PIP mode
• Open a video upper on the list
• It shows the previous one

(this was probably there since the media enhancement PR, but I didn't catch it before...)

Screen_recording_20260911_104255.mp4

I updated the PR. Seeing video overlay icon on video is expected but ratio of it needs to be fixed and latest commit includes the fix.

pr is updated

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/34587857929/artifacts/10194544775
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	58	58
Dodgy code	195	194
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	26
Performance	37	37
Security	19	19
Total	373	372

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[daniele-verducci]

It's all fixed, as far as I can see. And very very fast and smooth scrolling! Thank you! Approved.