Skip to content

fix: clear shared files after passing them to the chat - #7036

Merged
mahibi merged 2 commits into
stable-25.1.xfrom
fixSharedFilesAfterShare-stable-25.1
Nov 12, 2026
Merged

mahibi merged 2 commits into
stable-25.1.xfrom
fixSharedFilesAfterShare-stable-25.1

Conversation

@mahibi

@mahibi mahibi commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Clear shared files after passing them to the chat. The conversation list stays below the chat, so the next chat opened from it received the shared files again and showed their attachment preview.

Assisted-by: Claude Code:claude-opus-5-5


This is a hotfix only for branch stable-25.1.x

On master this does not happen thanks to #6989 (<- it will be backported to 25.1.x afterwards or we create 25.2. It should just not be released yet without further testing in a beta channel)


🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mahibi mahibi added this to the 25.1.1 milestone Nov 12, 2026
@mahibi
mahibi requested a review from rapterjet2004 November 12, 2026 10:42
@mahibi mahibi self-assigned this Nov 12, 2026
The conversation list stays below the chat, so the next chat opened from
it received the shared files again and showed their attachment preview.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi force-pushed the fixSharedFilesAfterShare-stable-25.1 branch from 83f9a84 to 99cce10 Compare November 12, 2026 11:06
@mahibi
mahibi marked this pull request as ready for review November 12, 2026 11:06
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit df0a350
Version 7036
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

…ve hint

Avoids SEO_SUBOPTIMAL_EXPRESSION_ORDER: the cheap version check comes first, so
isPipModePossible() is not called on Android 12 and later.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@github-actions

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings17137
Errors015

SpotBugs

CategoryBaseNew
Bad practice77
Correctness88
Dodgy code4040
Internationalization33
Malicious code vulnerability33
Performance77
Security1111
Total7979

@mahibi
mahibi merged commit abc113d into stable-25.1.x Nov 12, 2026
15 of 16 checks passed
@mahibi
mahibi deleted the fixSharedFilesAfterShare-stable-25.1 branch November 12, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants