stream: optimize forEach(), some(), every() and find() functions on Readable - #65890
Open
lukiano wants to merge 1 commit into
Open
stream: optimize forEach(), some(), every() and find() functions on Readable#65890lukiano wants to merge 1 commit into
lukiano wants to merge 1 commit into
Conversation
…eadable
Signed-off-by: Luciano Leggieri <230980@gmail.com>
Assisted-by: Sol 5.6
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
jasnell
approved these changes
Sep 8, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65890 +/- ##
========================================
Coverage 90.16% 90.17%
========================================
Files 771 771
Lines 265094 265299 +205
Branches 50367 50422 +55
========================================
+ Hits 239035 239234 +199
- Misses 17000 17015 +15
+ Partials 9059 9050 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm splitting my previous PR into smaller chunks, hoping the changes are easier to understand.
This one modifies the following iterator helpers:
forEach()some()every()find()Please see my previous PR that contains screenshots of benchmarks showcasing the performance improvements in this proposal.
Note that
someandeveryused to depend onfilterbut they now depend onfind.In terms of the logic inside
operators.js, it's not easy to view these changes as a diff because the previous logic almost entirely relied oncreateAsyncIterator, which is in a different file (readable.js) and the asynchronous iteration engine that v8 provides. The new proposal is an implementation from scratch that keeps the same compatibility evaluated by the tests, but with improved performance. It's better to consider both as black box implementations rather than trying to diff.