build: do not use bundled simdutf when built with --shared-simdutf - #65891
Open
aduh95 wants to merge 3 commits into
Open
build: do not use bundled simdutf when built with --shared-simdutf#65891aduh95 wants to merge 3 commits into
--shared-simdutf#65891aduh95 wants to merge 3 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
aduh95
force-pushed
the
shared-simdutf
branch
from
September 7, 2026 21:32
4703552 to
775944c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
added
dont-land-on-v22.x
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65891 +/- ##
=======================================
Coverage 90.16% 90.17%
=======================================
Files 771 771
Lines 265434 265434
Branches 50450 50452 +2
=======================================
+ Hits 239332 239343 +11
+ Misses 17045 17034 -11
Partials 9057 9057 🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 8, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Original commit message:
Rewrite simdutf include paths to allow getting it from system
Change-Id: I2b7b4cb452c22ed72e0935662c3c7477954bc205
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8319848
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109702}
Refs: v8/v8@a0607c5
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
shared-simdutf
branch
from
September 9, 2026 08:50
20a9a57 to
f5856b5
Compare
Collaborator
Collaborator
Collaborator
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that v8/v8@a0607c5 has landed, we can mixing more than one simdutf instance. I'm also using this opportunity to clean up the
$CONFIG_FLAGSgeneration isshell.nix, to not explicitly pass the lib and header paths to test our default values.