Repository navigation
Conversation
traceCallback() defaults to a frozen context but writes the callback's result or error to it. Allocate a fresh context when undefined is passed and subscribers are present, matching traceSync() and tracePromise(). Set the prototype after allocation to avoid dictionary-mode properties. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs-github-bot
added
diagnostics_channel
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66481 +/- ##
==========================================
+ Coverage 90.39% 90.42% +0.03%
==========================================
Files 792 790 -2
Lines 275697 275439 -258
Branches 52868 52828 -40
==========================================
- Hits 249208 249072 -136
+ Misses 16892 16765 -127
- Partials 9597 9602 +5
🚀 New features to boost your workflow:
|
bengl
approved these changes
Oct 6, 2026
bengl
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
traceCallback()defaults to a frozen context but writes the callback's result or error to it. Allocate a fresh context whenundefinedis passed and subscribers are present, matchingtraceSync()andtracePromise().Set the prototype after allocation to avoid dictionary-mode properties.