Skip to content

Give each run its own folder when the name has dots or brackets - #1512

Open
mh-masum6875 wants to merge 1 commit into
obss:mainfrom
mh-masum6875:fix/increment-path-literal-names
Open

mh-masum6875 wants to merge 1 commit into
obss:mainfrom
mh-masum6875:fix/increment-path-literal-names

Conversation

@mh-masum6875

Copy link
Copy Markdown
Contributor

increment_path() searched for earlier runs with the unescaped path as a glob pattern and the path stem as a regular expression. With a run name such as v1.0 or exp(1), or a project folder such as runs [v2], the earlier runs weren't found, so from the third run on sahi predict returned the second run's folder again and wrote into it.

Treats the path as literal text and matches on the full name.

Added test_increment_path_never_returns_existing_path: 5 cases fail on main and pass here. 600 plain names give identical results before and after.

increment_path() searched for earlier runs with the unescaped path as
a glob pattern and the path stem as a regular expression. With a run
name such as "v1.0" or "exp(1)", or a project folder such as
"runs [v2]", the earlier runs weren't found, so from the third run on
'sahi predict' returned the second run's folder again and wrote into
it.

Treat the path as literal text and match on the full name.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant