Repository navigation
Give each run its own folder when the name has dots or brackets - #1512
Open
mh-masum6875 wants to merge 1 commit into
Open
mh-masum6875 wants to merge 1 commit into
mh-masum6875 wants to merge 1 commit into
Conversation
increment_path() searched for earlier runs with the unescaped path as a glob pattern and the path stem as a regular expression. With a run name such as "v1.0" or "exp(1)", or a project folder such as "runs [v2]", the earlier runs weren't found, so from the third run on 'sahi predict' returned the second run's folder again and wrote into it. Treat the path as literal text and match on the full name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
increment_path()searched for earlier runs with the unescaped path as a glob pattern and the path stem as a regular expression. With a run name such asv1.0orexp(1), or a project folder such asruns [v2], the earlier runs weren't found, so from the third run onsahi predictreturned the second run's folder again and wrote into it.Treats the path as literal text and matches on the full name.
Added
test_increment_path_never_returns_existing_path: 5 cases fail onmainand pass here. 600 plain names give identical results before and after.