Repository navigation
Leave the given COCO dict unchanged when remapping category ids - #1514
Open
mh-masum6875 wants to merge 1 commit into
Open
mh-masum6875 wants to merge 1 commit into
mh-masum6875 wants to merge 1 commit into
Conversation
Loading with remapping_dict wrote the new ids back into the dict that
was passed in. Loading the same dict again then raised KeyError, or
with a mapping such as {1: 2, 2: 1} quietly undid the remap. CocoVid
changed its category list the same way.
Remap copies of the category and annotation entries instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading with
remapping_dictwrote the new ids back into the dict that was passed in. Loading the same dict again then raisedKeyError: 0, or with a mapping such as{1: 2, 2: 1}quietly undid the remap.CocoVidchanged its category list the same way.Remaps copies of the category and annotation entries instead.
New test fails on
main(KeyError: 0) and passes here. Over 1000 random datasets the first load gives identicalCocoobjects before and after; the caller's dict was changed in 651 of them before and in none after.