Skip to content

Read .wmv and upper-case video file names as videos in predict - #1517

Open
mh-masum6875 wants to merge 1 commit into
obss:mainfrom
mh-masum6875:fix/wmv-video-extension
Open

mh-masum6875 wants to merge 1 commit into
obss:mainfrom
mh-masum6875:fix/wmv-video-extension

Conversation

@mh-masum6875

Copy link
Copy Markdown
Contributor

VIDEO_EXTENSIONS listed wmv without its dot, and predict compared the source suffix case-sensitively. A clip.wmv or CLIP.AVI source was handled as a single image and failed with TypeError: image with shape: 3 is not supported.

Adds the dot and compares the lower-cased suffix.

New parametrized test: 2 cases fail on main and pass here. I also ran real clips written with OpenCV; the wmv and AVI ones fail on main and finish here.

VIDEO_EXTENSIONS listed "wmv" without its dot, and predict compared the
source suffix case-sensitively. A clip.wmv or CLIP.AVI source was
therefore handled as a single image and failed when it was opened as
one. Add the dot and compare the lower-cased suffix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant