Repository navigation
Read .wmv and upper-case video file names as videos in predict - #1517
Open
mh-masum6875 wants to merge 1 commit into
Open
mh-masum6875 wants to merge 1 commit into
mh-masum6875 wants to merge 1 commit into
Conversation
VIDEO_EXTENSIONS listed "wmv" without its dot, and predict compared the source suffix case-sensitively. A clip.wmv or CLIP.AVI source was therefore handled as a single image and failed when it was opened as one. Add the dot and compare the lower-cased suffix.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIDEO_EXTENSIONSlistedwmvwithout its dot, and predict compared the source suffix case-sensitively. Aclip.wmvorCLIP.AVIsource was handled as a single image and failed withTypeError: image with shape: 3 is not supported.Adds the dot and compares the lower-cased suffix.
New parametrized test: 2 cases fail on
mainand pass here. I also ran real clips written with OpenCV; the wmv and AVI ones fail onmainand finish here.