Skip to content

Bridge Python3_INCLUDE_DIRS when only the unversioned Python module was found #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
take-cheeze wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bridge Python3_INCLUDE_DIRS when only the unversioned Python module was found #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@ if(ONNX_BUILD_PYTHON)
Python 3
REQUIRED COMPONENTS Interpreter Development.Module
OPTIONAL_COMPONENTS Development.SABIModule)
# nanobind's own CMake config reads the VERSIONED, plural "Python3_INCLUDE_DIRS"
# variable specifically -- it is not populated by the unversioned
# find_package(Python ...) above (a different CMake module/variable
# namespace from find_package(Python3 ...)). On a normal host build,
# find_package(Python3) elsewhere in the dependency graph (e.g. onnx's own
# CMakeLists.txt) has usually already populated it, so this goes unnoticed;
# cross-compiling (e.g. for wasm32-emscripten) can hit this find_package(Python)
# call with nothing else in the build ever having populated the Python3_*
# variables, and nanobind then fails outright with "Python.h file not found"
# even though Development.Module was found immediately above. Bridge it
# explicitly rather than relying on some other part of the build to have
# incidentally populated it first.
if(NOT DEFINED Python3_INCLUDE_DIRS AND DEFINED Python_INCLUDE_DIRS)
set(Python3_INCLUDE_DIRS "${Python_INCLUDE_DIRS}")
endif()
nanobind_add_module(onnx_opt_cpp2py_export "onnxoptimizer/cpp2py_export.cc" STABLE_ABI)
target_link_libraries(onnx_opt_cpp2py_export PRIVATE onnx_optimizer)
endif()
Expand Down
Loading