Repository navigation
Conversation
joepio
marked this pull request as ready for review
October 28, 2026 15:57
Member
Author
|
Complexity review at 7bbc73c: OK. Two points:
Generated by Claude Code |
This was referenced Oct 28, 2026
Host theme tokens with dark mode, a tree that fits its width with layer bands and highlighted edges, state markers, a card layout for the detail panel, an empty state, and interactive lessons with Start and a link field.
joepio
force-pushed
the
claude/education-design
branch
from
November 9, 2026 12:21
7bbc73c to
0e3efe4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AHutN3sUdZuXNuGu6i7hwf
What
learning, paths and ontology terms unchanged. Catalog entry staysenabled: false(ontology gate, see learning: enable Leerboom as an experimental drive app #704).apps/learning/0.2.0/ui.js; 0.1.0 untouched.--t-*theme tokens (light and dark), tree fits the width (pans on mobile with a hint), level bands, faint edges with the selected skill and goal path in the accent colour, state markers that differ by shape and colour, legend, progress bar, detail card with state badge, advice callout, toggleable "I master this", path chips, lesson rows with icon, kind and duration, a real empty state; "Load starter tree" disappears once skills exist.lesson-format: interactivewithlesson-contentpointing at a resource (e.g. an installed mini app) shows "Start"; an unlinked one offers a paste-and-link field. No ontology change. Starter tree's optics, magnetism and oscillation lessons renamed to "… (interactief)".Verified
node --test integrations/tooling/*.test.mjs: 238 pass;node --test ontology-kit/*.test.mjs: 130 passapps.mjs check --published origin/main: OKScreenshots (desktop 1440 and 390px, light and dark) were shared with Joep in chat.
Not verified
"Start" against a real installed mini app (those come in a separate PR). Ontology descriptions still say "Leerboom" (generated files behind the gate).
Generated by Claude Code