Skip to content

Keep mobile resource menu visible - #1638

Closed
joepio wants to merge 1 commit into
developfrom
codex/mobile-resource-menu
Closed

joepio wants to merge 1 commit into
developfrom
codex/mobile-resource-menu

Conversation

@joepio

@joepio joepio commented Sep 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Reserve the right edge of the mobile navbar for the resource menu, even when other actions grow.
  • Collapse action labels on narrow bars and keep Tags and Share identifiable by their button titles.
  • Add a Chromium regression check for 390 px and 320 px viewports that measures the menu button and opens it.

Verification

  • Full browser workspace lint passed (pnpm run -r lint; existing warnings only).
  • Data browser typecheck passed.
  • All four modified translation catalogs passed msgfmt --check.
  • The focused Chromium test passed against the original checkout with the same navbar changes. A repeat from this isolated PR worktree stopped during dev-drive setup: the temporary Vite setup served a symlinked Loro WASM file outside its allowed root, and its reused server binary predates the current identity protocol. The layout assertion was not reached in that repeat.

@joepio

joepio commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Trekmeester: not batched yet, it needs a rebase with changes. Develop (#1828/#1876) now renders the Tags button only when a resource has tags, so this PR's e2e assertion on navbar-tags-button span fails on a fresh resource. Develop also added a non-resource More menu inside ButtonArea, which this PR's overflow: hidden could clip; it should move into MenuSlot too. Then check the layout at 320px again.

joepio added a commit that referenced this pull request Oct 5, 2026
… chat, search, CI) (#2060)

Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).

joepio commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included.


Generated by Claude Code

@joepio joepio closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant