Skip to content

Stop the sync page repeating account requests every five seconds #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joepio wants to merge 2 commits into from
Closed

Stop the sync page repeating account requests every five seconds #1914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b523f
Stop the sync page repeating account requests every five seconds
joepio Sep 29, 2026
502e5af
Merge remote-tracking branch 'origin/develop' into claude/project-thr…
joepio Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion browser/data-browser/src/routes/SyncRoute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,16 @@ function SyncCard({
);
}

/**
* Keeps the previous object when a poll brought nothing new. `managedInfo` is a
* dependency of the effects that ask the portal about the account and this
* drive's enrollment, so a fresh object every five seconds made the page repeat
* `/api/me` and `/api/sync-enrollments` for as long as it stayed open.
*/
function sameInfo(prev: ManagedInfo, next: ManagedInfo): ManagedInfo {
return JSON.stringify(prev) === JSON.stringify(next) ? prev : next;
}

function SyncPage() {
const store = useStore();
const [status, setStatus] = useState<StoreSyncStatus>(() =>
Expand Down Expand Up @@ -932,7 +942,7 @@ function SyncPage() {

const poll = () =>
fetchManagedInfo(serverUrl).then(info => {
if (!cancelled) setManagedInfo(info);
if (!cancelled) setManagedInfo(prev => sameInfo(prev, info));
});

void poll();
Expand Down