Repository navigation
Conversation
…ead-u8vgm0-report-failing-commits
This was referenced Sep 30, 2026
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
Author
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Before: a write that the server kept refusing (for instance "Parent of … not found" when a server never received a drive's root) was retried in the background and only ever showed up in the browser console. Sentry saw nothing, so a drive that could not sync was invisible to us.
After: when the same queued write has failed four drains in a row, one Sentry warning "Commit keeps failing" is sent per failure streak. It is grouped by server and error text with identifiers removed, and carries the subject and failure count. The write keeps retrying exactly as before; nothing changes for the user.
How
LocalOutboxgets anonRepeatedFailurehook that fires once when an entry's failure count reachesREPORT_AFTER_FAILURES.Storeemits it asStoreEvents.CommitRepeatedlyFailing, andreportRepeatedCommitFailuresinhelpers/sentry.ts(wired inApp.tsx) forwards it to Sentry when Sentry is enabled. Tests: the outbox reports once at the threshold without blocking or dropping the entry, and the Sentry fingerprint ignores resource ids. Lint passes. Not tried against a live Sentry project.Generated by Claude Code