Repository navigation
Conversation
…lain GET /ws ATOMIC-BROWSER-1R: archiveStoredAgent compared the stored agent subject to the requested one as strings, so asking for an agent in the atomic:agent: spelling failed with 'no stored key' for a key the device holds. It now compares identities, and keeps the key under the spelling the device stores it in. ATOMIC-SERVER-M: a request to /ws that is not a WebSocket upgrade failed the handshake and answered 500, which Sentry reported as an incident (18 events, from a crawler). It now answers 400.
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
Author
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: signing in with an account while a guest identity held a workspace could fail to keep the previous identity with "no stored key for atomic:agent:..." even though the device held that key (ATOMIC-BROWSER-1R). The server also answered a plain
GET /wsthat is not a WebSocket upgrade with a 500, which error reporting counted as an incident: 18 events from a crawler (ATOMIC-SERVER-M).After: the handover finds the key whichever spelling of the agent it is asked for, and a non-upgrade request to
/wsgets a 400.1R:
archiveStoredAgentcompared the stored subject to the requested one as strings, while the caller had matched them by identity (sameAgent). It now compares identities and keeps the key under the spelling the device stores it in. The new vitest case fails ondevelopwith the same "no stored key" error.M: the handshake error from
WsResponseBuilder::startwas converted to a 500. It is nowAtomicServerError::bad_request. The new server test asserts 400 and gets 500 without the change.Checked locally: vitest for
agentStorage, oxlint and oxfmt,cargo clippy -D warningsand the new server test.Not changed on purpose: ATOMIC-BROWSER-1T (one event from a Chimera crawler on the portal sign-in page) and ATOMIC-BROWSER-1S (one stale chunk after a deploy).
Requested by Joep