Skip to content

ci: revert JDK 25 bump, restore pinned JDK 17 - #2044

Merged
toddbaert merged 1 commit into
mainfrom
revert/jdk-25-bump
Sep 18, 2026
Merged

toddbaert merged 1 commit into
mainfrom
revert/jdk-25-bump

Conversation

@toddbaert

Copy link
Copy Markdown
Member

Reverts #2038, which was auto-created and automerged by renovate's new uses-with runtime-version detection and broke the build. We pin JDK 17 in these workflows intentionally for API compatibility testing.

Org-level prevention: open-feature/community-tooling#127 disables uses-with deps so renovate no longer touches runtime versions in action inputs.

Reverts #2038. We intentionally pin JDK 17 in these workflows for API compatibility testing.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
toddbaert requested review from a team as code owners September 18, 2026 12:21
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 41d15cc6-ab0c-4196-a9ba-b99c69d5573c

📥 Commits

Reviewing files that changed from the base of the PR and between 3571de5 and c3755f4.

📒 Files selected for processing (2)
  • .github/workflows/merge.yml
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The merge and release GitHub Actions workflows now provision Temurin JDK 17 instead of JDK 25. All other workflow steps remain unchanged.

Changes

JDK Version Update

Layer / File(s) Summary
Workflow JDK configuration
.github/workflows/merge.yml, .github/workflows/release.yml
Both workflows now request Java 17.0.20+101 for Maven build and deployment operations instead of 25.0.4+101.0.LTS.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: aepfli

Merge Risk: ⚪ Minimal · up to c3755

This change restores the intended JDK 17 CI and release environment without an identified current-head risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: reverting the JDK 25 update and restoring the pinned JDK 17 configuration.
Description check ✅ Passed The description directly explains the JDK 17 restoration, the failed JDK 25 update, the API compatibility purpose, and the Renovate configuration change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (962694c) to head (c3755f4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2044      +/-   ##
============================================
+ Coverage     92.70%   93.27%   +0.57%     
- Complexity      730      732       +2     
============================================
  Files            60       60              
  Lines          1741     1741              
  Branches        203      203              
============================================
+ Hits           1614     1624      +10     
+ Misses           77       69       -8     
+ Partials         50       48       -2     
Flag Coverage Δ
unittests 93.27% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toddbaert
toddbaert merged commit ef95b30 into main Sep 18, 2026
11 checks passed
@toddbaert
toddbaert deleted the revert/jdk-25-bump branch September 18, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant