Repository navigation
refactor: adopt template 90ff6da6, kpt.* packages, wallet root on ForkAppShell, web sign-in via relay - #2070
Open
therajanmaurya wants to merge 5 commits into
Open
therajanmaurya wants to merge 5 commits into
therajanmaurya wants to merge 5 commits into
Conversation
… 90ff6da6 before sync
Contributor
WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
Move fork code out of template-owned roots before the strict-mirror sync: - core-base/network org.mifos.corebase.network (12 files) -> core/network (same package); libs/mifos-loans depends on core:network - drop the template.core.base.* shims; consumers import kpt.core.base.* directly - drop the unused core/analytics + core-base/analytics modules - Compose plugins for core/common|data|network move to module-deps.gradle.kts - .template-sync-holds: 99 held paths (app shell, platform files, fork docs, never-touch cla-check) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…enMF#316) Strict-mirror template sync from 6fe88bad (48 template commits): - engine overlay + 3-way merges; 9 conflicts resolved keeping the fork shell (RootNav, Koin, nav bridge) and the template's ForkFeatureRegistry / privacy consent / deep links / onboarding install - ksp-registration: 16 wallet entities + DAOs (@DbEntity/@dbdao) and 16 stores (@StoreProvider, 14 @Cachekey) replace the hand-written AppDatabase / AppStoreRegistry / StoreModule; Room v10 (9->10 adds framework_write_conflicts + drafts.attemptCount), ledger in app-profile/migration-ledger.yaml - registry seams seeded (demo-stripped), feature/onboarding seeded, fork features in feature-deps - 99 fork paths held in .template-sync-holds (cmp-shared app shell, security gates, platform files, docs) - fork includes moved to settings.local.gradle.kts (project graph identical, 66 projects) - product-health 37 passed / 1 warn / 0 failed; assembleProdDebug + desktop compile green Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ppShell, web relay for GitHub Pages
…ules out of di/, dependency baseline, docs refresh
therajanmaurya
changed the title
therajanmaurya
marked this pull request as ready for review
November 6, 2026 12:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings Mifos Pay onto kmp-project-template
90ff6da6(template PR openMF/kmp-project-template#316) and finishes the migration onto the template's structure, so later template syncs apply cleanly. The web app now signs in and loads home end to end (verified with the demo account onmifos-bank-2). Supersedes #2069.Changes
Template sync
90ff6da6: sync engine and ownership contract, Kotlin 2.4.20, Room 3.1, the Store5 offline-first stack and the per-layerFork*seams.Package migration
org.mifospay.core.*/org.mifospay.feature.*→kpt.core.*/kpt.feature.*across everycore/andfeature/module (~800 files).UserData,LanguageConfig, password utilities, the home/profile/settings screens), the wallet's version lives in a.forksubpackage and is imported explicitly, so it never resolves to the template's.MifosPreferencesmerged intoForkPreferencesRepository, which extends the template'sUserPreferencesRepository.services,utils,localAssets) sits under themainaccess point package, matching the template's network layout.App shell
MifosPaySharedAppis gone. The wallet root (login, passcode, background re-auth lock, 401 dialog, the four-tab shell) isForkAppRootin the fork-ownedcmp.navigation.registry.app, rendered through the template'sForkAppShell.root. Every platform entry point (Android, iOS, desktop, web) reaches it through the template'sSharedApp.ComposeApp,AppViewModel,RootNav*, navigation,KoinModulesandKoinExtare back to the template versions; the wallet's Koin modules register throughForkFeatureRegistry, its module dependencies throughfeature-deps.gradle.kts.org.mifospay.MainActivity(the manifest launches the template activity).Web
/corsrelay (Cloudflare Pages worker) for the Fineract servers, which reject browser-origin requests; an allowlisted origin (https://openmf.github.io) can use it cross-origin, so a GitHub Pages build works too.Build and tests
Verification
Known follow-ups (pre-existing on
dev)docs/architecture/tree/resolve as template-owned, so their authored sections can't be written in the fork yet (template ownership fix needed).keystores/contains committed keystore files; signing material should move to the secrets vault.🤖 Generated with Claude Code