Repository navigation
Fix acm-opp-app regex to match compound suite naming - #855
Merged
openshift-merge-bot[bot] merged 2 commits intoSep 20, 2026
Merged
openshift-merge-bot[bot] merged 2 commits into
openshift-merge-bot[bot] merged 2 commits into
Conversation
The ^acm-opp-app$ regex can never match because BigQuery ingestion filters suites to lp-interop--%. Update the regex to ^lp-interop--OPP--acm-opp-app$ to match the actual compound suite naming convention. Companion fix to PR openshift-eng#853.
|
/assign |
neisw
reviewed
Sep 18, 2026
| Matchers: []config.ComponentMatcher{ | ||
| {SuiteRegEx: regexp.MustCompile(`^lp-interop--OPP--Observability`)}, | ||
| {SuiteRegEx: regexp.MustCompile(`^acm-opp-app$`)}, | ||
| {SuiteRegEx: regexp.MustCompile(`^lp-interop--OPP--acm-opp-app$`)}, |
Contributor
There was a problem hiding this comment.
Can this just be omitted and rely on the matcher below?
Contributor
Author
There was a problem hiding this comment.
Good catch — you're right, the broader ^lp-interop--OPP--acm matcher already covers this. Removed the redundant line in 3b132f4.
AI-generated. Review for accuracy.
The explicit ^lp-interop--OPP--acm-opp-app$ matcher is covered by the broader ^lp-interop--OPP--acm matcher. Removing per review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
Contributor
Author
|
/cc @amp-rh AI-generated. Review for accuracy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
^acm-opp-app$regex in the ACM OPP component matcher can never match because BigQuery ingestion filters suites tolp-interop--%. Update the regex to^lp-interop--OPP--acm-opp-app$to match the actual compound suite naming convention.Companion fix to #853.
Changes
pkg/components/lpinteropoppackm/component.go— Change second matcher regex from^acm-opp-app$to^lp-interop--OPP--acm-opp-app$Testing
go build .— passesgo test ./...— all packages pass./hack/go-lint.sh run ./...— 0 issuesAI-generated. Review for accuracy.
@amp-rh requested via Chai Bot