Skip to content

[core] ci_entrypoint: fournos: don't crash in the resolve step - #267

Merged
kpouget merged 5 commits into
openshift-psap:mainfrom
kpouget:resolv
Sep 24, 2026
Merged

kpouget merged 5 commits into
openshift-psap:mainfrom
kpouget:resolv

Conversation

@kpouget

@kpouget kpouget commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

crashes at this level are harder to troubleshoot (logs aren't captured in MLFlow)

Summary by CodeRabbit

  • Bug Fixes
    • Fournos configuration resolution failures are now recorded with clearer error details, helping CI report what went wrong.
    • Resolver pod logs are saved as CI artifacts when available, making failures easier to investigate.
    • CI checks the Fournos job’s resolver status before continuing, so reported resolver errors are surfaced rather than overlooked.
  • Improvements
    • Artifact export now uses the same lenient handling as configuration resolution.

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d7dfc285-3d08-41c6-b81a-6eeeaf0d6bff

📥 Commits

Reviewing files that changed from the base of the PR and between 0e74f89 and caec1f3.

📒 Files selected for processing (3)
  • projects/core/ci_entrypoint/fournos.py
  • projects/core/ci_entrypoint/fournos_resolve.py
  • projects/core/library/config.py
 ________________________________________________________________________
< Obi-Wan Kenobi has taught me well. I sense a disturbance in your code. >
 ------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test fournos skel hellz

@psap-forge-bot

Copy link
Copy Markdown
🔴 Submission of skel hellz failed after 1 minute, 55 seconds 🔴

Error: FournosJobFailureError: FOURNOS Job 'forge-skel-20260924-074047' failed: Tasks Completed: 2 (Failed: 2, Cancelled 0), Skipped: 1

/test fournos skel hellz

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test fournos skel hellz

@psap-forge-bot

Copy link
Copy Markdown

✅ Execution of skel | hellz completed with success after 0s ✅

forge-skel-20260924-074935 -- skel hellz


Execution Engine Configuration

clusterless: true
exclusive: false
executionEngine:
  forge:
    args:
    - hellz
    configOverrides: {}
    project: skel
owner: kpouget
pipeline: forge-test-only

MLFlow links


Pipeline Step Details

❓ 00__preflight 0 seconds (🔴 25E)

📤 02__export-artifacts (🟡 1W)

@psap-forge-bot

Copy link
Copy Markdown
🔴 Submission of skel hellz failed after 1 minute, 15 seconds 🔴

Error: FournosJobFailureError: FOURNOS Job 'forge-skel-20260924-074935' failed: Tasks Completed: 2 (Failed: 1, Cancelled 0), Skipped: 1

/test fournos skel hellz

@psap-forge-bot

Copy link
Copy Markdown

✅ Execution of skel | hellz completed with success after 0s ✅

forge-skel-20260924-074935 -- skel hellz


Execution Engine Configuration

clusterless: true
exclusive: false
executionEngine:
  forge:
    args:
    - hellz
    configOverrides: {}
    project: skel
owner: kpouget
pipeline: forge-test-only

MLFlow links


Pipeline Step Details

❓ 00__preflight 0 seconds (🔴 25E)

📤 02__export-artifacts (🟡 1W)

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test fournos skel hellz

@psap-forge-bot

Copy link
Copy Markdown

✅ Execution of skel | hellz completed with success after 0s ✅

forge-skel-20260924-080323 -- skel hellz


Execution Engine Configuration

clusterless: true
exclusive: false
executionEngine:
  forge:
    args:
    - hellz
    configOverrides: {}
    project: skel
owner: kpouget
pipeline: forge-test-only

MLFlow links


Pipeline Step Details

❓ 00__preflight 0 seconds (🔴 25E)

📤 02__export-artifacts (🟡 1W)

@psap-forge-bot

Copy link
Copy Markdown
🔴 Submission of skel hellz failed after 1 minute, 26 seconds 🔴

Error: FournosJobFailureError: FOURNOS Job 'forge-skel-20260924-080323' failed: Tasks Completed: 2 (Failed: 1, Cancelled 0), Skipped: 1

/test fournos skel hellz

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test fournos skel hellz

@psap-forge-bot

Copy link
Copy Markdown

✅ Execution of skel | hellz completed with success after 0s ✅

forge-skel-20260924-080649 -- skel hellz


Execution Engine Configuration

clusterless: true
exclusive: false
executionEngine:
  forge:
    args:
    - hellz
    configOverrides: {}
    project: skel
owner: kpouget
pipeline: forge-test-only

MLFlow links


Pipeline Step Details

❓ 00__preflight 0 seconds (🔴 25E)

📤 02__export-artifacts (🟡 1W)

@psap-forge-bot

Copy link
Copy Markdown
🔴 Submission of skel hellz failed after 1 minute, 20 seconds 🔴

Error: FournosJobFailureError: FOURNOS Job 'forge-skel-20260924-080649' failed: Tasks Completed: 2 (Failed: 1, Cancelled 0), Skipped: 1

/test fournos skel hellz

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown

@kpouget: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fournos caec1f3 link true /test fournos

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test fournos skel

@psap-forge-bot

Copy link
Copy Markdown

✅ Execution of skel completed with success after 10s ✅

forge-skel-20260924-081058 -- skel


Execution Engine Configuration

clusterless: true
exclusive: false
executionEngine:
  forge:
    args: []
    configOverrides: {}
    project: skel
owner: kpouget
pipeline: forge-test-only

MLFlow links


Pipeline Step Details

✅ 00__preflight 1 second

✅ 01__test 9 seconds

📤 02__export-artifacts


✅ Post-processing Status /workspace/artifacts/01__test/002__postprocessing

@kpouget

kpouget commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

looks good, merging

@kpouget
kpouget merged commit c2c3cc8 into openshift-psap:main Sep 24, 2026
4 of 7 checks passed
@kpouget
kpouget deleted the resolv branch September 24, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant