Repository navigation
Conversation
Display detailed profile information (input tokens, output tokens, and description) when users select an ISL/OSL profile. This helps users understand what each profile tests and why certain token combinations are chosen. - Added _PROFILE_DETAILS metadata for all guidellm profiles (0/0, 1000/1000, 8000/800, 128/128) - Added get_profile_tooltip() to format profile details as markdown - Updated ISL/OSL selectbox with help text and info box showing selected profile details Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Link profile definitions to the official workloads.yaml from the RHAIIS orchestration config. Include actual token distributions, request rates, and accurate descriptions for each profile: - Profile 1 (1000/1000): Balanced baseline with rates [1, 50, 100, 200, 300] - Profile 6 (128/128): Multi-turn conversations with 5 turns and 512-token prefix - Profile 7 (8000/800): Long context with variable token distributions Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Include hover/selection details for all profiles from workloads.yaml: - Profile 1 (1000/1000): Balanced baseline - Profile 2 (512/2048): Variable distributions - Profile 3 (2048/128): Prompt-heavy context - Profile 4 (8000/1000): Long context with samples - Profile 5 (100000/1000): Extreme context (100K+ tokens) - Profile 6 (128/128 display): Multi-turn conversations with prefix - Profile 7 (8000/800): Heterogeneous with variable distributions - Real Dataset (0/0): Real conversation data - Custom: User-configurable stub Display profile-specific details (samples, turns, prefix tokens) when available. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Change statistical notation from σ to 'stdev' for clarity in profile tooltips. Improves readability for users unfamiliar with mathematical notation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
These profiles are not actual guidellm workloads from workloads.yaml. Keep tooltips for the 7 official profiles (1-7) only. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Remove redundant text about testing baseline performance across varied concurrency. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add help parameter to selectbox to show tooltip hint when hovering over the help icon. This provides guidance to users that selecting a profile will show detailed specifications. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Move profile details and tooltip function to profile_config.py for reuse across all dashboards. This allows consistent profile hover information across RHAIIS, LLM-D, CPU, and other views. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add help text and detailed profile info boxes to: - Main dashboard (RHAIIS view) - Performance Trends section - CPU dashboard - Workload filter Allows users to see guidellm specifications for all profiles across all dashboard views. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add token extraction from profile display names to match with PROFILE_DETAILS. Handles formats like: - "Profile B: Variable Workload (512/2k)" -> "512/2048" - "1k/1k" -> "1000/1000" - "8k/800" -> "8000/800" This enables profile info boxes to appear for all dashboard views with correct mapping. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
CPU dashboard has different profiles not in the guidellm workload set. Keep profile tooltips only for RHAIIS and LLM-D dashboards. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
aas008
marked this pull request as draft
September 9, 2026 19:54
Rates are test parameters, not profile specifications. Keep only the core profile attributes: token counts, samples, turns, and prefix. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Show only token counts and relevant parameters. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Keep profile name for clarity. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add visible caption below profile selectbox instead of relying on help icon. Makes it clearer that selecting a profile displays specifications. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Fix indentation and use the shared get_profile_details() function instead of non-existent _PROFILE_DETAILS dict. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Create custom HTML dropdown component that displays rich tooltips on hover for each profile option, showing token counts and descriptions. Features: - Hover tooltips with profile details (name, tokens, samples, turns) - Smooth animations and styling - Keyboard accessible - Clean integration with Streamlit Implemented in llmd_dashboard.py with custom_dropdown.py component.
…o icon - Replace broken custom HTML dropdown with JS MutationObserver that injects hover tooltips onto native Streamlit selectbox [role="option"] elements - Use st.components.v1.html() to inject JS (st.markdown strips <script> tags) - Add blue ℹ info icon (CSS scoped via .profile-info-icon class) on ISL/OSL selectboxes only, other help icons remain as default ? - Update profile text per reviewer feedback: shorter names, remove verbose descriptions, add prefix_count field for multi-turn - Add help="Hover over dropdown options..." to all ISL/OSL selectboxes - Works across RHAIIS (Performance Plots, Trends, Compare) and LLM-D views Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aas008
marked this pull request as ready for review
September 11, 2026 15:23
…ooltip - Move PROFILE_DETAILS and get_profile_details() from profile_config.py into custom_dropdown.py to eliminate a separate file - Remove unused imports (get_profile_tooltip, PROFILE_DETAILS) from dashboard.py and llmd_dashboard.py - Replace hardcoded profile_names dict with aliases from PROFILE_DETAILS - Fix tooltip not showing for (2k/128): add rounded k-decoded variants so JS can match 2048→2k→2000 lookups - Delete profile_config.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
…rror guard - Add type annotation for PROFILE_DETAILS (dict[str, dict[str, Any]]) - Add variant fallback for rounded k-notation in get_profile_details() - Guard details['description'] with .get() in dashboard.py, llmd_dashboard.py - Add keyboard accessibility (aria-selected tracking, aria-live region) - Add 22 tests for profile details lookup and display variants - Fix ruff import formatting in test file Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add hover tooltips to ISL/OSL profile selectbox options across RHAIIS and LLM-D dashboards. When users open the dropdown and hover over a profile option, a tooltip shows the guidellm workload specification (token counts, samples, turns, etc.).
New files
custom_dropdown.py— Streamlit'sst.selectboxdoes not support per-option hover tooltips natively — it only allows a singlehelpstring for the entire widget. To work around this,custom_dropdown.pyinjects JavaScript into the parent document viast.components.v1.html(). AMutationObserverwatches for[role="option"]elements as the dropdown opens and attachesmouseenter/mouseleaveevent listeners that show a positioned tooltip with the profile's guidellm specification. Also containsPROFILE_DETAILS(the profile definitions) and tags ISL/OSL help icons with a CSS class for the ℹ️ icon styling.Changes to existing files
dashboard.py— Callsinject_profile_tooltips()on page load. Addshelp="Hover over dropdown options to see guidellm profile details"to ISL/OSL selectboxes in Performance Plots, Performance Trends, and Compare Versions sections.dashboard_styles.py— CSS for the ℹ️ info icon on ISL/OSL selectboxes (scoped via.profile-info-iconclass, does not affect other help icons).llmd_dashboard.py— Same tooltip integration for LLM-D dashboard: callsinject_profile_tooltips(), restores nativest.selectbox(was briefly using a custom HTML dropdown that couldn't return values), addshelp=parameter.Adding tooltips for new profiles
No tooltip appears in the dropdown until an entry is added to
PROFILE_DETAILSincustom_dropdown.py:The k-notation variant (e.g.
(4k/512)) is auto-generated. For non-standard display names, add"aliases": ["Custom Name"]to the entry.Profiles shown in tooltips
🤖 Generated with Claude Code