OCPBUGS-71193: Group details page renders a kebab button instead of Actions button

[deik0]

Analysis / Root cause:
The Group details page (GroupDetailsPage) renders the LazyActionMenu without specifying a variant prop. The default variant is ActionMenuVariant.KEBAB (three-dot icon), which does not render the "Actions" dropdown button that other resource detail pages display. This is inconsistent with the rest of the console UI.

Solution description:
Added variant={ActionMenuVariant.DROPDOWN} to the LazyActionMenu in GroupDetailsPage, matching the pattern used by other detail pages such as PDBDetailsPage. This renders the standard "Actions" dropdown button instead of the kebab menu.

Additional info:
Single-line fix aligning Group details page with the standard console pattern for resource action menus.

Summary by CodeRabbit

• Style
  • Updated the group details action menu to use a dropdown-style appearance.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@deik0: This pull request references Jira Issue OCPBUGS-71193, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
The Group details page (GroupDetailsPage) renders the LazyActionMenu without specifying a variant prop. The default variant is ActionMenuVariant.KEBAB (three-dot icon), which does not render the "Actions" dropdown button that other resource detail pages display. This is inconsistent with the rest of the console UI.

Solution description:
Added variant={ActionMenuVariant.DROPDOWN} to the LazyActionMenu in GroupDetailsPage, matching the pattern used by other detail pages such as PDBDetailsPage. This renders the standard "Actions" dropdown button instead of the kebab menu.

Additional info:
Single-line fix aligning Group details page with the standard console pattern for resource action menus.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1852a8b3-0b68-4e67-9166-f2cfb5befbd6

📥 Commits

Reviewing files that changed from the base of the PR and between 9995a3a and f68f6da.

📒 Files selected for processing (1)

• frontend/public/components/group.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The group details page imports ActionMenuVariant and passes ActionMenuVariant.DROPDOWN to its LazyActionMenu.

Changes

Group action menu

Layer / File(s)	Summary
Apply dropdown variant frontend/public/components/group.tsx	The group details action menu uses the DROPDOWN variant.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: logonoff

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the root cause and solution, but it omits required testing and review information. It does not provide screenshots or a recording for the visual change, test setup, test cases…	Complete all template sections. Add before-and-after screenshots or a recording, test setup details, test cases, browser conformance results, and reviewers or assignees. Also resolve the reported invalid OCPBUGS-71193 Jira reference or upda…

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Jira issue and the primary UI change: replacing the kebab button with the Actions button on the Group details page. The Jira issue validity concern does not make the t…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only frontend/public/components/group.tsx. The added lines import ActionMenuVariant and set variant={ActionMenuVariant.DROPDOWN} on LazyActionMenu. No Ginkgo test decl…
Test Structure And Quality	✅ Passed	The pull request changes only frontend/public/components/group.tsx. The patch updates LazyActionMenu to use ActionMenuVariant.DROPDOWN and adds no Ginkgo tests or cluster operations. Therefore, …
Microshift Test Compatibility	✅ Passed	The review range changes only frontend/public/components/group.tsx. The added lines import ActionMenuVariant and set variant={ActionMenuVariant.DROPDOWN} on LazyActionMenu. No Ginkgo tests, te…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only frontend/public/components/group.tsx. It adds an ActionMenuVariant.DROPDOWN prop to an existing LazyActionMenu; it does not add Ginkgo or other e2e tests. Therefore…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only frontend/public/components/group.tsx. The patch adds ActionMenuVariant.DROPDOWN to a LazyActionMenu on the Group details page and does not add or modify deplo…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only frontend/public/components/group.tsx. The patch adds an ActionMenuVariant import and sets a React LazyActionMenu prop. The changed file contains no stdout, lo…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only frontend/public/components/group.tsx. The patch adds an ActionMenuVariant.DROPDOWN prop to a React LazyActionMenu and adds its import. No Ginkgo e2e tests, test files, IPv4 a…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only frontend/public/components/group.tsx. The changed lines add ActionMenuVariant and set variant={ActionMenuVariant.DROPDOWN} on LazyActionMenu. The enum and r…
Container-Privileges	✅ Passed	The pull request changes only frontend/public/components/group.tsx. The additions import ActionMenuVariant and set LazyActionMenu to ActionMenuVariant.DROPDOWN. The patch contains no container…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request changes only frontend/public/components/group.tsx. It adds the ActionMenuVariant import and sets variant={ActionMenuVariant.DROPDOWN} on LazyActionMenu. The existing resource …

Full details: Description check

Explanation

The description explains the root cause and solution, but it omits required testing and review information. It does not provide screenshots or a recording for the visual change, test setup, test cases, browser conformance, or reviewers and assignees.

Resolution

Complete all template sections. Add before-and-after screenshots or a recording, test setup details, test cases, browser conformance results, and reviewers or assignees. Also resolve the reported invalid OCPBUGS-71193 Jira reference or update the title to use a valid issue.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-71193, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-gcp-console-techpreview

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deik0, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikram-raj]

/verified by @vikram-raj

[openshift-ci-robot]

@vikram-raj: This PR has been marked as verified by @vikram-raj.

Details

In response to this:

/verified by @vikram-raj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/retest

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 9995a3a and 2 for PR HEAD f68f6da in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 991e3f3 and 1 for PR HEAD f68f6da in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD afe3510 and 0 for PR HEAD f68f6da in total

[openshift-merge-bot]

/hold

Revision f68f6da was retested 3 times: holding

[vikram-raj]

/unhold
/retest

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 31db805 and 2 for PR HEAD f68f6da in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 7dbb22e and 1 for PR HEAD f68f6da in total

[openshift-ci]

@deik0: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	f68f6da	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.