Skip to content

OCPBUGS-122257: Discover OAuth route before generating cert in HCP OAuth procedure - #119713

Open
Patrickdsa00 wants to merge 1 commit into
openshift:mainfrom
Patrickdsa00:hcp-oauth-cert-fix
Open

OCPBUGS-122257: Discover OAuth route before generating cert in HCP OAuth procedure#119713
Patrickdsa00 wants to merge 1 commit into
openshift:mainfrom
Patrickdsa00:hcp-oauth-cert-fix

Conversation

@Patrickdsa00

Copy link
Copy Markdown

Rework the "Configuring OAuth server certificates for a hosted cluster" procedure so it no longer relies on a misleading placeholder hostname:

  • Remove the api-custom-cert-sample-hosted.sample-hosted.example.com placeholder, which implied the OAuth route lives on the API endpoint domain. The route is served on the management cluster's apps wildcard domain, consistent with the HyperShift documentation.
  • Reorder the steps so the OAuth route is discovered and stored in OAUTH_HOST before the test certificate is generated, so the certificate SAN uses the correct hostname and no certificate regeneration is needed.
  • Normalize placeholder names to the module's convention (<management_cluster_name>, <base_domain>).
  • Export OAUTH_HOST, add the missing shell prompt, fix the "kubconfig" typo, and clean up trailing whitespace.

Version(s):
4.20, 4.21, and 4.22

Issue:
https://redhat.atlassian.net/browse/OCPBUGS-122257

Link to docs preview:

QE review:

  • QE has approved this change.

…uth procedure

Rework the "Configuring OAuth server certificates for a hosted cluster"
procedure so it no longer relies on a misleading placeholder hostname:
- Remove the api-custom-cert-sample-hosted.sample-hosted.example.com
  placeholder, which implied the OAuth route lives on the API endpoint
  domain. The route is served on the management cluster's `apps` wildcard
  domain, consistent with the HyperShift documentation.
- Reorder the steps so the OAuth route is discovered and stored in
  OAUTH_HOST before the test certificate is generated, so the certificate
  SAN uses the correct hostname and no certificate regeneration is needed.
- Normalize placeholder names to the module's convention
  (<management_cluster_name>, <base_domain>).
- Export OAUTH_HOST, add the missing shell prompt, fix the "kubconfig"
  typo, and clean up trailing whitespace.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Patrickdsa00: This pull request references Jira Issue OCPBUGS-122257, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Rework the "Configuring OAuth server certificates for a hosted cluster" procedure so it no longer relies on a misleading placeholder hostname:

  • Remove the api-custom-cert-sample-hosted.sample-hosted.example.com placeholder, which implied the OAuth route lives on the API endpoint domain. The route is served on the management cluster's apps wildcard domain, consistent with the HyperShift documentation.
  • Reorder the steps so the OAuth route is discovered and stored in OAUTH_HOST before the test certificate is generated, so the certificate SAN uses the correct hostname and no certificate regeneration is needed.
  • Normalize placeholder names to the module's convention (<management_cluster_name>, <base_domain>).
  • Export OAUTH_HOST, add the missing shell prompt, fix the "kubconfig" typo, and clean up trailing whitespace.

Version(s):
4.20, 4.21, and 4.22

Issue:
https://redhat.atlassian.net/browse/OCPBUGS-122257

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 10, 2026
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2026
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

Hi @Patrickdsa00. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Patrickdsa00

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Patrickdsa00: This pull request references Jira Issue OCPBUGS-122257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants