Skip to content

openstack-k8s-operators dependency bump branch: main - #708

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
openstack-dependency-bump/main
Oct 25, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
mainfrom
openstack-dependency-bump/main

Conversation

@github-actions

Copy link
Copy Markdown

Automated changes by create-pull-request GitHub action

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 8816baf0-b761-49f4-9d35-67f48a376897
Commits

Reviewing files that changed from the base of the PR and between d12258a and ea1e591.

Files ignored due to path filters: 2
  • api/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
Files selected for processing: 6
  • api/bases/manila.openstack.org_manilaapis.yaml
  • api/bases/manila.openstack.org_manilas.yaml
  • api/go.mod
  • config/crd/bases/manila.openstack.org_manilaapis.yaml
  • config/crd/bases/manila.openstack.org_manilas.yaml
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Service overrides can now change exposed port numbers by matching a port by name. Port values must be between 1 and 65535; other port settings remain unchanged.
    • Omitting port overrides preserves the generated Service ports. Overrides for unmatched port names are rejected.

The ManilaAPI and Manila CRD schemas add named Service port overrides. The Go module files also update dependency versions.

Changes: Service Port Overrides

Layer / File(s) Summary
Define Service port overrides
api/bases/manila.openstack.org_manilaapis.yaml, api/bases/manila.openstack.org_manilas.yaml, config/crd/bases/manila.openstack.org_manilaapis.yaml, config/crd/bases/manila.openstack.org_manilas.yaml
The schemas add port override entries with a required port name and a required port value from 1 to 65535. The descriptions state that only the exposed port changes, unmatched names are rejected, and other port fields remain unchanged. Omitting ports leaves generated ports unchanged.

Dependency Updates

Layer / File(s) Summary
Update Go module versions
api/go.mod, go.mod
The module files update versions for infra-operator/apis, lib-common modules, and other listed dependencies.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: stuggi

Merge Risk: Minimal · up to ea1e5

No actionable merge-blocking issue is established; the change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "openstack-k8s-operators dependency bump branch: main" names the main change, a dependency bump from the main branch of openstack-k8s-operators. It is somewhat generic and does not name the …
Description check Passed The description states the change is automated by the create-pull-request GitHub action. This relates to the changeset, which is an automated dependency update across go.mod files and generated CRD ma…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "openstack-k8s-operators dependency bump branch: main" names the main change, a dependency bump from the main branch of openstack-k8s-operators. It is somewhat generic and does not name the ManilaAPI or Manila CRD port override changes, but the changeset does include dependency updates in go.mod files and api/go.mod. The title is partially related: it describes a real part of the change but not the CRD schema changes.

Full details: Description check

Explanation

The description states the change is automated by the create-pull-request GitHub action. This relates to the changeset, which is an automated dependency update across go.mod files and generated CRD manifests. It does not describe the specific changes, but the check is lenient and the description is not off-topic.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/82854904911149e6b13f95345e61b145

✔️ manila-s2i-content-provider SUCCESS in 1h 47m 18s
⚠️ manila-s2i-test-cephfs SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
❌ openstack-k8s-operators-content-provider FAILURE in 26m 34s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Warning:
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job manila-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.

@fmount

fmount commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/ab51eac80dc74e9aac964b2c5defcdae

✔️ manila-s2i-content-provider SUCCESS in 2h 54m 50s
✔️ manila-s2i-test-cephfs SUCCESS in 1h 52m 11s
✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 48m 29s
✔️ manila-operator-kuttl SUCCESS in 40m 28s

Warning:
File ansible/tmp/a0f06aea9760444081280c8e553b80ea found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-operator-kuttl. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/c9bb980878444c21a7245f1e6faa2cec found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-operator-kuttl. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/1e1f4b268a564ed29aff432a9be2a605 found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-operator-kuttl. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/8da8c6e6e5a845d1b3ed7199ff373f9e found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-operator-kuttl. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/a0f06aea9760444081280c8e553b80ea found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/multinode-autohold.yml for job manila-operator-kuttl. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/3390b92f7b3145abbf2fd63ef6260ab9 found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/c2f6a51ba96b4a908d36c7627694f2c1 found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/collect-logs.yml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/3390b92f7b3145abbf2fd63ef6260ab9 found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/multinode-autohold.yml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/c2f6a51ba96b4a908d36c7627694f2c1 found in build home directory during playbook github.com/openstack-k8s-operators/ci-framework/ci/playbooks/multinode-autohold.yml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File ansible/tmp/3390b92f7b3145abbf2fd63ef6260ab9 found in build home directory during playbook review.rdoproject.org/config/playbooks/crc/print-machineconfigpool.yaml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/known_hosts.old found in build home directory during playbook review.rdoproject.org/config/playbooks/base-minimal/post-logs.yaml for job manila-s2i-test-cephfs. Add to preserve-home-paths if safe, or otherwise remove.
File .ssh/config found in build home directory during playbook github.com/openstack-k8s-operators/s2i-openstack-containers/playbooks/container-ci/zuul/pre.yaml for job manila-s2i-content-provider. Add to preserve-home-paths if safe, or otherwise remove.

@fmount fmount left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 67df8bc into main Oct 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant