Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
EinLama
left a comment
There was a problem hiding this comment.
Hey @AileenK13 , thank you for this PR. It renders a useful chart and already has a lot going for it 👏 well done!
Before we can merge it, there is some feedback that should be addressed. Also, some tests (we call them specs) should be added. I know that this is already on your todo-list, just listing it here for the sake of completeness.
The CI uncovered some issues during an automatic check (linting, style, etc.), please have a look at these, too. I didn't add an additional review comment for most of these and let them stand for themselves.
I know that this is a lot of feedback. Please inquire further when something is unclear or you require support 👍
Thank you for your work 🙇
EinLama
left a comment
There was a problem hiding this comment.
There are some TypeScript linting errors in the chart component, you can run npx eslint <file> locally to see them. For example, there are some semicolons missing. Please have a look and fix them 🧹
Ticket
https://community.openproject.org/wp/AGILE-60
What are you trying to accomplish?
Creating a “Created vs. Resolved” Graph for the Sprint Report
Screenshots
What approach did you choose and why?
Based on the burndown chart, another widget was developed that displays the tasks created and completed during a sprint.
AI involvement
None/Assisted – No AI assistance used OR only autocomplete/pasted snippets. I effectively wrote and understand all the code.
Merge checklist