Skip to content

Fix ##3748, part of #6233: Migrate to using R8 [Blocked: #6235] - #6236

Draft
BenHenning wants to merge 3 commits into
migrate-to-kotlin-1.9from
migrate-to-r8
Draft

Fix ##3748, part of #6233: Migrate to using R8 [Blocked: #6235]#6236
BenHenning wants to merge 3 commits into
migrate-to-kotlin-1.9from
migrate-to-r8

Conversation

@BenHenning

@BenHenning BenHenning commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Explanation

Fixes #3748
Fixes part of #6233

TODO: Finish description.

Essential Checklist

  • The PR title starts with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The explanation section above starts with "Fixes #bugnum: " (If this PR fixes part of an issue, use instead: "Fixes part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@BenHenning
Migrate to using R8.
058ad1d 
This was largely written by Gemini CLI with some re-writing by me and
additional prompted adjustments. This introduces an R8 wrapper to
leverage R8 with Bazel 6 rather than forcing the shift to R8 in Bazel 7
(with the rules_android upgrade).

Note that this does not keep Proguard compatibility mode for R8 so there
may be aggressive additional reductions happening. Also, Gemini CLI was
a bit eager in how many Proguard rules were removed so there may be new
crashes introduced. App testing is absolutely necessary for these
changes.
@BenHenning BenHenning mentioned this pull request Apr 20, 2026
Open
@oppiabot

oppiabot Bot commented Apr 27, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 27, 2026
@oppiabot oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 28, 2026
@oppiabot

oppiabot Bot commented May 5, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 5, 2026
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 7, 2026
@oppiabot

oppiabot Bot commented May 14, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 14, 2026
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 19, 2026
@oppiabot

oppiabot Bot commented May 29, 2026

Copy link
Copy Markdown

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot Bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 29, 2026
@oppiabot oppiabot Bot closed this Jun 5, 2026
This was referenced Oct 23, 2026
Open
Open
@BenHenning BenHenning mentioned this pull request Nov 5, 2026
Open
7 tasks
@BenHenning
Merge branch 'migrate-to-kotlin-1.9' into migrate-to-r8
2e6edd9 
Conflicts:
	.bazelrc
	build_flavors.bzl
	config/proguard/kotlin-proguard-rules.pro
	third_party/maven_install.json
	third_party/versions.bzl
@BenHenning BenHenning changed the title Fix part of #6233: Migrate to using R8 [Blocked: #6235] Fix ##3748, part of #6233: Migrate to using R8 [Blocked: #6235] Nov 7, 2026
@BenHenning BenHenning reopened this Nov 7, 2026
@oppiabot oppiabot Bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BenHenning BenHenning

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenHenning @adhiamboperes