Repository navigation
Fix part of #5035: Add SplashActivity locale reset test - #6540
Open
Abhishekgit01 wants to merge 1 commit into
Open
Abhishekgit01 wants to merge 1 commit into
Abhishekgit01 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes part of #5035
Adds a SplashActivity test for reopening the activity after onboarding state is reset while the app-scoped locale handler remains initialized. It checks that the second launch routes to onboarding and retains the display locale from the first launch.
Essential Checklist
Fix part of #5035: ....Fixes part of #5035.scripts/assetsfiles have their rationale included (no such files are changed).developand is up-to-date withdevelop(checked againstcd3f5f5415ffbda8f7e7730304376bdb571ac2f7immediately before publication).@Reviewer, PTAL) after the PR is created.Testing
bazel --batch test --nocache_test_results --test_output=errors //app/src/sharedTest/java/org/oppia/android/app/splash:SplashActivityTest— passed; 135 test cases, zero failures or errors.SplashActivityTest.kt— passed.git diff --check— passed.Disclosure of LLM Usage