Repository navigation
chore: remove final parameters log on resource creation - #296
Merged
Merged
Conversation
The request body is already shown by the global --debug flag. Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
FrostByte0x
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
Final parameters/Installation parameterslogs that were always printed when creating a resource (and when reinstalling an instance).They made the normal command output noisy and developer-oriented:
2026/10/09 16:10:01 Final parameters:
{
"targetSpec": { ... }
}
They are redundant: the global
--debugflag already dumps the full HTTP request, body included. Users who need to inspect what is sent to the API can use--debug.Type of change
Checklist:
go mod tidy