Repository navigation
Conversation
Add SSL certificate management commands to the iploadbalancing
service:
- ssl list <service_name>: list SSL certificate IDs
(GET /ipLoadbalancing/{serviceName}/ssl)
- ssl get <service_name> <ssl_id>: retrieve a SSL certificate
(GET /ipLoadbalancing/{serviceName}/ssl/{id})
- ssl create <service_name>: add a custom SSL certificate, with
--certificate, --chain, --key and --display-name flags, and
support for --from-file, --init-file, --editor and stdin
(POST /ipLoadbalancing/{serviceName}/ssl)
- ssl delete <service_name> <ssl_id>: delete a custom SSL certificate
(DELETE /ipLoadbalancing/{serviceName}/ssl/{id})
Tests cover flag and argument parsing, error paths and successful
execution using mocked API responses. Documentation regenerated
with make doc.
Signed-off-by: Martín Alfano <43454843+elvenarg@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add commands to inspect and apply the pending configuration changes
of an iploadbalancing service:
- pending-changes <service_name>: list pending changes per zone
(GET /ipLoadbalancing/{serviceName}/pendingChanges)
- refresh <service_name> [--zone]: apply the pending configuration
changes, on all zones or on the given one
(POST /ipLoadbalancing/{serviceName}/refresh)
Tests cover argument parsing, filtering, error paths and successful
execution using mocked API responses. Documentation regenerated
with make doc.
Signed-off-by: Martín Alfano <43454843+elvenarg@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add SSL certificate management and configuration apply commands to
ovhcloud iploadbalancing.Two commits, each building and passing tests on its own:
1. SSL certificates (
ovhcloud iploadbalancing ssl ...)ssl list <service_name>GET /ipLoadbalancing/{serviceName}/sslssl get <service_name> <ssl_id>GET /ipLoadbalancing/{serviceName}/ssl/{id}ssl create <service_name>POST /ipLoadbalancing/{serviceName}/sslssl delete <service_name> <ssl_id>DELETE /ipLoadbalancing/{serviceName}/ssl/{id}ssl createtakes--certificate,--chain,--keyand--display-name(PEM content, as inwebhosting ssl service-create), and goes throughcommon.CreateResource, so--from-file,--init-file,--editorand stdin are supported.certificateandkeyare required, as in the API schema.2. Pending changes (
ovhcloud iploadbalancing ...)pending-changes <service_name>GET /ipLoadbalancing/{serviceName}/pendingChangesrefresh <service_name> [--zone]POST /ipLoadbalancing/{serviceName}/refreshpending-changessupports--filter.refreshapplies the pending configuration on all zones, or only on--zone, and returns the created task.Notes for reviewers:
ssl list: the API returns a bare list of IDs; they are rendered as[{"id": 1}, ...]so they go throughdisplay.RenderTablelike other lists.ssl get/ssl deletereject a non-numericssl_idbefore calling the API.Type of change
Checklist:
go mod tidymake fmt,make build,make wasm,make testandmake docwere run;doc/ovhcloud.mdis unchanged.🤖 Generated with Claude Code