Skip to content

[tests-only][full-ci] test: add tests for opening files with # and ? in new tabs - #12865

Merged
ishabaral merged 1 commit into
owncloud:masterfrom
Asmitapaudel:test/add-special-character-file-tests
Sep 18, 2026
Merged

ishabaral merged 1 commit into
owncloud:masterfrom
Asmitapaudel:test/add-special-character-file-tests

Conversation

@Asmitapaudel

@Asmitapaudel Asmitapaudel commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Add Playwright end-to-end tests to cover the fix introduced in PR #12740, which fixes opening files whose names contain # or ? in a new tab.

The tests verify that files containing these special characters can be opened correctly using Ctrl+Click/middle-click and that the opened file is displayed correctly in the file viewer.

Folders containing # or ? are not included in these tests because folders use a different route producer (folderLinkUtils.getFolderLink) and are not affected by the change in PR #12740.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
    • Locally
    • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kw-security

kw-security commented Sep 1, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 5 times, most recently from 5131d13 to 1e540b6 Compare September 3, 2026 04:25
@ishabaral ishabaral changed the title [tests-only] test: add tests for opening files with # and ? in new tabs [tests-only][full-ci] test: add tests for opening files with # and ? in new tabs Sep 3, 2026
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from 1e540b6 to 7eaee68 Compare September 3, 2026 04:26
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 4 times, most recently from ec52fbb to 2b6e6d4 Compare September 4, 2026 11:20
@Asmitapaudel
Asmitapaudel marked this pull request as ready for review September 7, 2026 05:29
@Asmitapaudel
Asmitapaudel requested a review from a team as a code owner September 7, 2026 05:29
@ishabaral ishabaral mentioned this pull request Sep 7, 2026
14 of 16 tasks
Comment thread web/tests/e2e/specs/file-action/fileViewer.spec.ts Outdated
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 2 times, most recently from 6deeb5b to a41dedc Compare September 7, 2026 12:12
Comment thread web/tests/e2e/specs/file-action/fileViewer.spec.ts Outdated
Comment thread web/tests/e2e/support/objects/app-files/resource/actions.ts Outdated
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from a41dedc to e36268a Compare September 8, 2026 04:19
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from e36268a to 3b43aca Compare September 8, 2026 05:03
Comment thread web/tests/e2e/specs/file-action/fileViewer.spec.ts
Comment thread web/tests/e2e/specs/file-action/fileViewer.spec.ts Outdated
Comment thread web/tests/e2e/specs/file-action/fileViewer.spec.ts Outdated
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 2 times, most recently from 55cab6c to 14a8651 Compare September 10, 2026 11:16
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from 14a8651 to f6458b7 Compare September 10, 2026 11:17
Comment thread web/tests/e2e/support/objects/app-files/resource/index.ts Outdated
Comment thread web/tests/e2e/support/objects/app-files/resource/actions.ts Outdated
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from f6458b7 to af0eb1f Compare September 11, 2026 04:18
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from af0eb1f to cbf9eed Compare September 11, 2026 05:51
ishabaral
ishabaral previously approved these changes Sep 11, 2026
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 3 times, most recently from e8bc2c8 to a4e51fb Compare September 18, 2026 03:24
@ishabaral
ishabaral dismissed their stale review September 18, 2026 05:33

The e2e-app-provider pipeline is constantly failing, please fix it

@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch 3 times, most recently from 40c63dd to 645dabf Compare September 18, 2026 08:43
@Asmitapaudel
Asmitapaudel force-pushed the test/add-special-character-file-tests branch from 645dabf to df0933c Compare September 18, 2026 08:49
@ishabaral
ishabaral merged commit a700f0c into owncloud:master Sep 18, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants