Skip to content

chore(deps): pin js-yaml 4.x to 4.3.2 to clear npm audit - #272

Merged
SebTardif merged 1 commit into
mainfrom
chore/pin-js-yaml-4.3.2
Sep 16, 2026
Merged

SebTardif merged 1 commit into
mainfrom
chore/pin-js-yaml-4.3.2

Conversation

@SebTardif

Copy link
Copy Markdown
Contributor

Pin the 4.x js-yaml line to 4.3.2 so the required npm audit check can pass again.

Problem

npm audit --audit-level=high fails on main and on every open Dependabot PR:

  • GHSA-2883-xcg3-v3hh: maxTotalMergeKeys does not count empty merge sources
  • Affected: js-yaml >=4.0.0 <4.3.2
  • Pulled in by mocha and @secretlint (via @vscode/vsce)

Required check npm audit therefore blocks:

Change

  • Add override js-yaml@4: 4.3.2 so the 5.x copy used by vscode-extension-tester stays on 5.x
  • Lockfile: js-yaml 4.3.1 -> 4.3.2

Validation

  • npm audit --audit-level=high reports 0 vulnerabilities
  • npm ls js-yaml shows 4.3.2 (overridden) and 5.4.1 (tester)
  • npm run check after the pin

Keep the 5.x copy used by vscode-extension-tester on its own line.
Unblocks the required npm audit check on Dependabot PRs.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
@SebTardif
SebTardif marked this pull request as ready for review September 16, 2026 18:00
@SebTardif
SebTardif enabled auto-merge (squash) September 16, 2026 18:00
@SebTardif
SebTardif merged commit 8426fc0 into main Sep 16, 2026
23 checks passed
@SebTardif
SebTardif deleted the chore/pin-js-yaml-4.3.2 branch September 16, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant