chore(deps): pin js-yaml 4.x to 4.3.2 to clear npm audit - #272
Merged
Merged
Conversation
Keep the 5.x copy used by vscode-extension-tester on its own line. Unblocks the required npm audit check on Dependabot PRs. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
September 16, 2026 18:00
SebTardif
enabled auto-merge (squash)
September 16, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the 4.x
js-yamlline to 4.3.2 so the requirednpm auditcheck can pass again.Problem
npm audit --audit-level=highfails on main and on every open Dependabot PR:maxTotalMergeKeysdoes not count empty merge sourcesjs-yaml>=4.0.0 <4.3.2@secretlint(via@vscode/vsce)Required check
npm audittherefore blocks:Change
js-yaml@4: 4.3.2so the 5.x copy used byvscode-extension-testerstays on 5.xjs-yaml4.3.1 -> 4.3.2Validation
npm audit --audit-level=highreports 0 vulnerabilitiesnpm ls js-yamlshows 4.3.2 (overridden) and 5.4.1 (tester)npm run checkafter the pin