[BUGFIX] Expand "$var" inside URL-encoded Explore panel links - #285
Merged
Merged
Conversation
colivi
force-pushed
the
fix/panel-link-vars-encoded-url
branch
2 times, most recently
from
September 9, 2026 16:27
344cb25 to
09173ac
Compare
There was a problem hiding this comment.
🟡 Changes recommended
URL reconstruction can change link targets and discard repeated query parameters.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes variable expansion inside URL-encoded Explore panel links.
Changes:
- Adds URL-aware variable replacement with unit tests.
- Integrates replacement into rendered dashboard and panel links.
- Exports the new utility.
File summaries
| File | Description |
|---|---|
dashboards/src/utils/replaceVariablesInUrl.ts |
Adds URL query-variable expansion. |
dashboards/src/utils/replaceVariablesInUrl.test.ts |
Tests URL substitution behavior. |
dashboards/src/utils/index.ts |
Exports the utility. |
dashboards/src/components/LinksDisplay/LinksDisplay.tsx |
Applies the utility to rendered links. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AntoineThebaud
changed the title
colivi
force-pushed
the
fix/panel-link-vars-encoded-url
branch
2 times, most recently
from
September 15, 2026 17:49
7d44efd to
6bba7f5
Compare
shahrokni
self-requested a review
September 16, 2026 11:29
shahrokni
reviewed
Sep 16, 2026
| const isAbsolute = /^https?:\/\//i.test(result); | ||
| const isProtocolRelative = result.startsWith('//'); | ||
| // Skip non-http schemes (mailto:, etc.) — only expand via step 1. | ||
| if (!isAbsolute && !isProtocolRelative && /^[a-z][a-z0-9+.-]*:/i.test(result)) { |
Contributor
There was a problem hiding this comment.
Improvement
For consistency and readability, could you please keep the result following statement in a descriptively named variable?
/^[a-z][a-z0-9+.-]*:/i.test(result)
Comment on lines
+268
to
+269
| const parseInput = isProtocolRelative ? `http:${result}` : result; | ||
| const u = new URL(parseInput, isAbsolute || isProtocolRelative ? undefined : 'http://perses.local'); |
Contributor
There was a problem hiding this comment.
Improvement
parsedUrl variable name would be better.
Comment on lines
+280
to
+284
| u.searchParams.delete(key); | ||
| for (const v of replacedValues) { | ||
| u.searchParams.append(key, v); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggestion
I think there might be a chance that the order of searchParams change. Ideally this should not happen.
Let's add a unit test as well.
Comment on lines
+78
to
+81
| const out = replaceVariablesInUrl('?data=%24var', vars); | ||
| expect(out.startsWith('?')).toBe(true); | ||
| expect(out).toContain('my-value'); | ||
| expect(out).not.toContain('%24var'); |
Contributor
There was a problem hiding this comment.
Improvement
Instead of 3 different expect statements, would it possible to simply compare it with the final string?
Comment on lines
+66
to
+70
| it('leaves absolute URLs absolute', () => { | ||
| const url = 'https://example.com/explore?q=$var'; | ||
| const out = replaceVariablesInUrl(url, vars); | ||
| expect(out).toMatch(/^https:\/\/example\.com\/explore\?q=my-value/); | ||
| }); |
Contributor
There was a problem hiding this comment.
colivi
force-pushed
the
fix/panel-link-vars-encoded-url
branch
from
September 16, 2026 12:51
d8b5d07 to
554b57f
Compare
replaceVariables only matched unencoded $name. Explore deep-links put PromQL in data= where $var is percent-encoded. - replaceVariablesInUrl next to replaceVariables - useReplaceVariablesInUrl hook (mirror useReplaceVariablesInString) - LinksDisplay uses the hook for all dashboard/panel link hrefs - rebuild query pairs in original order; preserve relative path prefix Signed-off-by: colivi <charles.olivi@gmail.com>
colivi
force-pushed
the
fix/panel-link-vars-encoded-url
branch
from
September 16, 2026 13:12
554b57f to
713feff
Compare
shahrokni
approved these changes
Sep 16, 2026
github-project-automation
Bot
moved this to Done
in Perses General Availability Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUGFIX] Expand "$var" inside URL-encoded Explore panel links
Description
Panel links that deep-link into Explore embed PromQL inside the "data=" query parameter. Dashboard template variables such as "$var" are percent-encoded there as "%24var".
"LinksDisplay" already called "useReplaceVariablesInString(link.url)", but only on the raw URL string. "VARIABLE_REGEX" looks for "$(\w+)", so it never matches "%24var". The Explore view then runs PromQL with literal "$var" and returns no series.
Fix: add "replaceVariablesInUrl":
Files
Screenshots
N/A (behavior of existing link menu; no visual layout change).
Before: Explore query contained literal "stack=~"$var"" (empty result).
After: same link opens Explore with the current dashboard variable value substituted inside "data=".
Checklist
following "catalog_entry" values: "FEATURE", "ENHANCEMENT", "BUGFIX", "BREAKINGCHANGE", "DOC","IGNORE".
UI Changes
(No layout change; unit tests cover the URL substitution. Happy to add a short before/after Explore screencast if preferred.)
(Covered by unit tests on "replaceVariablesInUrl"; no new E2E — pure string/URL logic, no time or network.)