Check acknowledged metadata in terminal Jepsen views - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terminal snapshots reduced registry and process-group entries to owner tokens. A receiver could retain revision 1 after its owner acknowledged revision 2 and still match the independent model, even when every internal index agreed with the stale value.
Fix
Carry the full public metadata map through snapshot EDN and construct the expected registry and PG values from each owner's acknowledged revision. Compare metadata exactly while retaining incarnation-scoped tokens for lifecycle and orphan detection.
Executable capture qualification repeatedly updates real owners, injects stale, missing, wrong-type, wrong-owner and extra metadata into consistent materialized indexes, and feeds actual captured EDN to the independent checker. The capture qualification is part of the normal Mix gate and remains separate from the Java-only pure checker.
Supporting information
This changes the terminal evidence schema: public values are metadata maps instead of token strings. Token-only historical captures cannot qualify as exact metadata evidence. Owner identity remains scoped by node, boot, logical owner and incarnation; raw PIDs are not exported.