Fail the CI on changes to migrated extensions - #5840
Merged
Conversation
lacatoire
force-pushed
the
pr/guard-migrated-extensions
branch
5 times, most recently
from
September 7, 2026 13:26
3f247b0 to
5337a09
Compare
The extensions carrying a MOVING_TO_DOC_EXTENSIONS_DO_NOT_CHANGE_HERE.md notice are maintained in php/doc-extensions. A pull request adding to or modifying one of their reference folders now fails with a message pointing at the other repository; deletions are left alone.
lacatoire
force-pushed
the
pr/guard-migrated-extensions
branch
from
September 7, 2026 13:32
5337a09 to
bed791f
Compare
alfsb
reviewed
Sep 7, 2026
Member
|
Too late as the code is done, but a simpler test would be cloning the repo with This test not need to be the most optimized one, as it will only necessary while the first mass migration is not completed. |
The check only reads path names, never file contents, so a tree:0 partial clone brings the full commit history for about the cost of the shallow one it replaces. The base commit is then always present, which removes the fetch-and-deepen loop and one of its failure paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fails the CI when a pull request adds to or modifies a
reference/folder of an extension that is migrating to php/doc-extensions, so that the notices merged in #5828 are enforced rather than only stated in prose.The list is not hardcoded: the job takes the extensions carrying the
MOVING_TO_DOC_EXTENSIONS_DO_NOT_CHANGE_HERE.mdnotice, read at the base commit, and matches them against the changed paths. Deletions are left alone, so removing those folders in batches is not blocked, and the check disappears on its own once the notices are gone.Two limits worth knowing before merging this:
skip-migrated-checklabel lets one through, which only a maintainer can add. Seven currently open pull requests would go red until rebased or labelled.