Skip to content

ci: drop nimja 0.10.3 workaround - #265

Closed
pietroppeter wants to merge 1 commit into
mainfrom
claude/project-thread-645dpc
Closed

pietroppeter wants to merge 1 commit into
mainfrom
claude/project-thread-645dpc

Conversation

@pietroppeter

Copy link
Copy Markdown
Owner

Requested by Pietro · project thread

The nimja release that broke the js build of the docs (enthus1ast/nimja#118) is fixed, so this removes the workaround from #261: nimble docsdeps no longer pins nimja@0.10.3 or deletes the nimja 0.10.4 package directory. The nimble file is back to what it was before #261.

The ubuntu-24.04 pin from #261 stays: it covers a separate problem (libpcre3 is not packaged on newer ubuntu images).

netlify_build_docs on this PR is the check that matters, since it builds docsrc/interactivity.nim with whatever nimja happyx pulls in.


Generated by Claude Code

Reverts the nimja part of #261. The ubuntu-24.04 pin stays, since
libpcre3 is still missing on newer images.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YPMoamS3J47kGd4SUSKiTX
@pietroppeter pietroppeter self-assigned this Oct 31, 2026
@pietroppeter
pietroppeter marked this pull request as draft October 31, 2026 14:38

Copy link
Copy Markdown
Owner Author

The docs build (tests in netlify_build_docs) fails here with the same error #261 worked around: nimja-0.10.4/nimja/nimjautils.nim(36, 3) Error: undeclared identifier: 'copyMem' while compiling docsrc/interactivity.nim to js.

The fix exists on nimja's default branch (addSlice now has a when defined(js) branch), but it hasn't been released yet: the newest tag is still 0.10.4, and that tag points at the broken code. Nimble resolves happyx's nimja dependency to that tag, so CI still gets the broken version.

I've marked this PR as a draft. It can go ahead once nimja tags a release with the fix (0.10.5 or later). Re-running CI at that point should be enough, with no code change.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Closing this in favor of #266. It makes the identical change to nimib.nimble (same resulting file), and its CI, including the docs build, is green now that nimja 0.11.0 ships the js fix.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants