Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Japanese date formats such as
%Y年%m月%d日wrap across two lines in the event editor even when the terminal has ample space. The field widths currently uselen(), which counts each Japanese marker as one character although it occupies two terminal columns.Measure date and time text with Urwid's text layout engine. Apply this to the standalone date editor and the event editor's date/time columns. The same fix covers wide characters in time formats such as
%H時%M分.Fixes #1412. This is independent of #1492: it changes editor-field sizing, while #1492 changes weekday-heading parsing. Neither branch depends on the other.
Validation on Python 3.14:
test_convert_to_dateleading-zero assertion. That same assertion fails on untouched upstream with identical dependencies (also documented in Fix weekday heading alignment for single-letter abbreviations #1492).git diff --checkpasses.