Repository navigation
Fix circular dependencies in filtered package listings - #5540
Open
Aditya123130 wants to merge 1 commit into
Open
Aditya123130 wants to merge 1 commit into
Aditya123130 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filtered
pio pkg listcan raiseRecursionErrorwhen an installed package leads into a dependency cycle that does not contain the requested package. Replace recursive filter matching with a traversal that visits each reachable installed package once. The same traversal can support the proposed project dependency inventory in #4247.The regression test uses local package manifests. It verifies that the filter skips a cycle without a match and still finds a target reachable on another branch. It fails on
developwithRecursionErrorand passes with this patch. All 26 focused package tests and the lint checks for changed Python files passed.Related to #4475.
Assisted by Codex.