Skip to content

add licensing section to enterprise configuration - #2368

Merged
calebdoxsey merged 2 commits into
mainfrom
cdoxsey/licensing
Oct 9, 2026
Merged

calebdoxsey merged 2 commits into
mainfrom
cdoxsey/licensing

Conversation

@calebdoxsey

Copy link
Copy Markdown
Contributor

Summary

Add a licensing section to the enterprise configuration page.

Related

AI disclosure

n/a

Checklist

  • reference any related issues
  • disclosed AI usage (or wrote "none") per AI_POLICY.md

@calebdoxsey
calebdoxsey requested a review from a team as a code owner September 29, 2026 00:17
@calebdoxsey
calebdoxsey requested review from kenjenkins and removed request for a team September 29, 2026 00:17
@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 30d55e7
🔍 Latest deploy log https://app.netlify.com/projects/pomerium-docs/deploys/6ac908ce1787e00008a1851a
😎 Deploy Preview https://deploy-preview-2368--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Low risk] Adds licensing documentation and screenshot to enterprise guides.

The documentation issues are non-blocking except that the changed imports must satisfy the repository’s explicit formatting requirement before merging.

Fix All in Claude CodeFindings

  1. P2 Offline option missing from config tab ▶
  2. P2 License requirements conflict ▶
  3. P2 Imports violate quote convention ▶

Summary

Adds a licensing section, a Console screenshot, and an offline-validation environment variable to the Enterprise configuration page.

  • The offline option is absent from the parallel config-file table, and the two license-key descriptions disagree.
  • The changed imports depart from the repository’s formatting convention.

Reviews (1) · Last reviewed commit: "add licensing section to enterprise conf..."

| <a className="entRef-anchor" id="grpc-addr">#</a><a href='#grpc-addr'>GRPC_ADDR</a> | The address to listen for gRPC on. | `:8702` |
| <a className="entRef-anchor" id="help">#</a><a href='#help'>HELP</a> | help for serve | `false` |
| <a className="entRef-anchor" id="license-key">#</a><a href='#license-key'>LICENSE_KEY</a> | Provide the license key issued by your account team. | none |
| <a className="entRef-anchor" id="license-key-validate-offline">#</a><a href='#license-key-validate-offline'>LICENSE_KEY_VALIDATE_OFFLINE</a> | Disable online validation of the license key. | `false`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Offline option missing from config tab

This page says its keys can be set in config.yaml or as environment variables, but LICENSE_KEY_VALIDATE_OFFLINE appears only in the environment-variable tab. Someone configuring an offline deployment from the config-file tab cannot find the YAML key. Add the corresponding entry there, or clarify that this option is environment-only.

Red test: the assertion fails because the config-file tab has no matching entry.

const {readFileSync} = require('node:fs');
const doc = readFileSync('content/docs/deploy/enterprise/configure.mdx', 'utf8');
const configTab = doc.split('<TabItem label="Config file keys"')[1];
console.assert(configTab.includes('license_key_validate_offline'));

Fix in Claude Code Fix in Codex

| <a className="entRef-anchor" id="disable-validation">#</a><a href='#disable-validation'>DISABLE_VALIDATION</a> | (deprecated, please update your configuration to set `VALIDATION_MODE=none` instead) Disable config validation. | `false` |
| <a className="entRef-anchor" id="grpc-addr">#</a><a href='#grpc-addr'>GRPC_ADDR</a> | The address to listen for gRPC on. | `:8702` |
| <a className="entRef-anchor" id="help">#</a><a href='#help'>HELP</a> | help for serve | `false` |
| <a className="entRef-anchor" id="license-key">#</a><a href='#license-key'>LICENSE_KEY</a> | Provide the license key issued by your account team. | none |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 License requirements conflict

The environment-variable entry no longer says the license key is required, while the corresponding config-file entry still says “Required.” Readers of the two tabs get conflicting provisioning instructions. Make the descriptions agree.

Red test: the assertion fails because only one entry contains “Required.”

const {readFileSync} = require('node:fs');
const doc = readFileSync('content/docs/deploy/enterprise/configure.mdx', 'utf8');
const rows = doc.split('\n').filter(line => />(?:LICENSE_KEY|license_key)<\/a>/.test(line));
console.assert(rows.length === 2 && rows.every(line => line.includes('Required:')));

Fix in Claude Code Fix in Codex

Comment thread content/docs/deploy/enterprise/configure.mdx Outdated
@calebdoxsey
calebdoxsey merged commit c70bff1 into main Oct 9, 2026
9 checks passed
@calebdoxsey
calebdoxsey deleted the cdoxsey/licensing branch October 9, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants